From: Jonathan Cameron <jic23@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] iio: adc: Add support for TI ADC1x8s102
Date: Thu, 27 Apr 2017 07:04:36 +0100 [thread overview]
Message-ID: <d86de554-eb66-d774-654f-aeaa213597c6@kernel.org> (raw)
In-Reply-To: <9a210132-854b-cf3e-da33-fc3d073ad491@kernel.org>
On 27/04/17 07:01, Jonathan Cameron wrote:
> On 26/04/17 10:01, Mika Westerberg wrote:
>> On Tue, Apr 25, 2017 at 06:12:12PM +0200, Jan Kiszka wrote:
>>> Now, do you also a suggestion where to put that 5 V reference voltage
>>> value that is hard-coded (via wiring) on the target boards for the ADC?
>>> That is now device-specific, not a controller parameter. Is there an
>>> ACPI-way to express such a parameter?
>>
>> You may put it into device property using _DSD (as long as you don't try
>> to represent regulators or so).
>>
>>> How would that be done for DTs?
>>
>> I don't know but you may look under Documentation/devicetree/bindings if
>> there is anything.
> Under DT it would be done using a fixed voltage regulator.
Though having actually looked at the driver, you presumably already know this
given you are requesting an appropriate regulator...
>>
>>> Plan B would be hard-coding in the code for now, waiting for a second,
>>> non-ACPI user to address it.
>>
>> Sounds reasonable.
> Somewhat of a pain to basically use a random value as the default going
> forward. Presumably this isn't the first ever ACPI table to need to
> tell use about a reference voltage...
>
> Mark, seen anything similar?
>
> I see https://www.kernel.org/doc/Documentation/arm64/arm-acpi.txt suggests
> that mapping to regulators isn't expected to ever happen...
>
> Jonathan
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-04-27 6:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 19:28 [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka
2017-04-24 20:05 ` Andy Shevchenko
2017-04-24 20:10 ` Andy Shevchenko
2017-04-24 20:37 ` Jan Kiszka
2017-04-24 20:32 ` Jan Kiszka
2017-04-24 21:25 ` Andy Shevchenko
2017-04-25 5:44 ` Jan Kiszka
2017-04-25 9:42 ` Andy Shevchenko
2017-04-25 10:53 ` Jan Kiszka
2017-04-25 11:27 ` Andy Shevchenko
2017-04-25 11:35 ` Mika Westerberg
2017-04-25 12:17 ` Jan Kiszka
2017-04-25 12:30 ` Mika Westerberg
2017-04-25 13:47 ` Jan Kiszka
2017-04-25 16:12 ` Jan Kiszka
2017-04-26 9:01 ` Mika Westerberg
2017-04-27 6:01 ` Jonathan Cameron
2017-04-27 6:04 ` Jonathan Cameron [this message]
2017-05-19 16:01 ` Mark Brown
2017-05-20 16:26 ` Jonathan Cameron
2017-05-22 10:06 ` Mark Brown
2017-04-25 6:06 ` Jan Kiszka
2017-04-25 7:31 ` Peter Meerwald-Stadler
2017-04-25 9:20 ` Andy Shevchenko
2017-04-25 9:32 ` Jan Kiszka
2017-04-25 11:23 ` Andy Shevchenko
2017-04-25 12:20 ` Mika Westerberg
2017-04-26 5:37 ` Jan Kiszka
2017-04-26 10:21 ` Andy Shevchenko
2017-04-27 6:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d86de554-eb66-d774-654f-aeaa213597c6@kernel.org \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pmeerw@pmeerw.net \
--cc=sascha.weisenberger@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox