From: Lu Baolu <baolu.lu@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu/vt-d: Change return type of dmar_insert_one_dev_info()
Date: Tue, 12 Apr 2022 13:13:38 +0800 [thread overview]
Message-ID: <d87918be-9ab8-ca6b-ea1f-b6e9fafb1d44@linux.intel.com> (raw)
In-Reply-To: <YlQ6feP5Dd9Ux18Y@infradead.org>
On 2022/4/11 22:26, Christoph Hellwig wrote:
> On Sat, Apr 09, 2022 at 09:30:06PM +0800, Lu Baolu wrote:
>> The dmar_insert_one_dev_info() returns the pass-in domain on success and
>> NULL on failure. This doesn't make much sense. Change it to an integer.
>
> Looks sensibel. Why not also merge it with domain_add_dev_info while
> you're at it?
It looks cleaner that way. Thanks a lot!
Best regards,
baolu
prev parent reply other threads:[~2022-04-12 5:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 13:30 [PATCH 1/1] iommu/vt-d: Change return type of dmar_insert_one_dev_info() Lu Baolu
2022-04-11 14:26 ` Christoph Hellwig
2022-04-12 5:13 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d87918be-9ab8-ca6b-ea1f-b6e9fafb1d44@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox