From: Bixuan Cui <cuibixuan@huawei.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>,
<linux-kernel@vger.kernel.org>, <linux-s390@vger.kernel.org>
Cc: <gor@linux.ibm.com>, <borntraeger@de.ibm.com>, <john.wanghui@huawei.com>
Subject: Re: [PATCH] s390/pci: move ioremap/ioremap_prot/ioremap_wc/ioremap_wt/iounmap to arch/s390/mm/ioremap.c
Date: Thu, 8 Apr 2021 10:47:53 +0800 [thread overview]
Message-ID: <d87946d9-dfa6-e279-e9e6-89f6276dc03c@huawei.com> (raw)
In-Reply-To: <a3005d2871d6571a436dacca2d93eb10cca54bed.camel@linux.ibm.com>
On 2021/4/6 19:14, Niklas Schnelle wrote:
> and move the have_mio variable out of the PCI only code or use a raw
> "#ifdef CONFIG_PCI". Obviously we don't have any actual users of
> ioremap() that don't depend on CONFIG_PCI but it would make it so that
> ioremap() exists and should actually function without CONFIG_PCI.
> The weird part though is that for anyone using it without CONFIG_PCI it
> would stop working if that is set and the machine doesn't have MIO
> support but would work if it does.
Well, Maybe it's better not to change it.And thank you for the explanation.
Thanks，
Bixuan Cui
prev parent reply other threads:[~2021-04-08 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:46 [PATCH] s390/pci: move ioremap/ioremap_prot/ioremap_wc/ioremap_wt/iounmap to arch/s390/mm/ioremap.c Bixuan Cui
2021-04-06 11:14 ` Niklas Schnelle
2021-04-08 2:47 ` Bixuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d87946d9-dfa6-e279-e9e6-89f6276dc03c@huawei.com \
--to=cuibixuan@huawei.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=john.wanghui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox