From: Binbin Wu <binbin.wu@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
kvm@vger.kernel.org, dave.hansen@intel.com, seanjc@google.com,
pbonzini@redhat.com, kas@kernel.org, rick.p.edgecombe@intel.com,
vishal.l.verma@intel.com, xiaoyao.li@intel.com,
chao.gao@intel.com
Subject: Re: [PATCH v2] x86/cpu: Skip reading MSR_IA32_PLATFORM_ID in virtualized environment
Date: Tue, 12 May 2026 09:57:58 +0800 [thread overview]
Message-ID: <d88d19f5-0a96-4115-97f7-8daf1edd625a@linux.intel.com> (raw)
In-Reply-To: <20260511100451.GBagGpw7jRBDdHkBgp@fat_crate.local>
On 5/11/2026 6:04 PM, Borislav Petkov wrote:
> On Thu, Apr 30, 2026 at 10:09:53AM +0800, Binbin Wu wrote:
>> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
>> index 37ac4afe0972..1bc0c350726c 100644
>> --- a/arch/x86/kernel/cpu/microcode/intel.c
>> +++ b/arch/x86/kernel/cpu/microcode/intel.c
>> @@ -147,6 +147,10 @@ u32 intel_get_platform_id(void)
>> if (intel_cpuid_vfm() <= INTEL_PENTIUM_II_KLAMATH)
>> return 0;
>>
>> + /* Don't try to read microcode bits when virtualized. */
>> + if (cpuid_ecx(1) & BIT(X86_FEATURE_HYPERVISOR & 0x1f))
>> + return 0;
>> +
>> /* get processor flags from MSR 0x17 */
>> native_rdmsr(MSR_IA32_PLATFORM_ID, val[0], val[1]);
>>
>>
>> base-commit: 9974969c14031a097d6b45bcb7a06bb4aa525c40
>> --
>
> Does that work too?
>
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index 18d2eff7a4b7..1b24de94bdd5 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -139,6 +139,9 @@ u32 intel_get_platform_id(void)
> {
> unsigned int val[2];
>
> + if (hypervisor_present)
hypervisor_present could be uninitialized if dis_ucode_ldr is true.
intel_get_platform_id() is also called during the normal cpu initialization.
> + return 0;
> +
> /*
> * This can be called early. Use CPUID directly instead of
> * relying on cpuinfo_x86 which may not be fully initialized.
>
next prev parent reply other threads:[~2026-05-12 1:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260430020953.1405535-1-binbin.wu@linux.intel.com>
2026-05-11 9:38 ` [PATCH v2] x86/cpu: Skip reading MSR_IA32_PLATFORM_ID in virtualized environment Kiryl Shutsemau
2026-05-11 10:04 ` Borislav Petkov
2026-05-12 1:57 ` Binbin Wu [this message]
2026-05-13 10:14 ` Borislav Petkov
2026-05-13 11:02 ` Binbin Wu
2026-05-13 11:08 ` Borislav Petkov
2026-05-13 12:20 ` Binbin Wu
2026-05-13 13:11 ` Borislav Petkov
2026-05-13 14:41 ` Binbin Wu
2026-05-13 20:00 ` Borislav Petkov
2026-05-13 20:06 ` [PATCH 1/2] x86/microcode: Do not access MSR_IA32_PLATFORM_ID when running as a guest Borislav Petkov
2026-05-13 20:07 ` [PATCH 2/2] x86/cpu: Move intel_get_platform_id() to cpu/intel.c Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d88d19f5-0a96-4115-97f7-8daf1edd625a@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox