From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E215DC433F5 for ; Tue, 22 Feb 2022 16:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233950AbiBVQTV (ORCPT ); Tue, 22 Feb 2022 11:19:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232395AbiBVQTT (ORCPT ); Tue, 22 Feb 2022 11:19:19 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C53AB1662E4 for ; Tue, 22 Feb 2022 08:18:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645546733; x=1677082733; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=xzT4HWXcvi+ina6Q/4wl+l8TTDcQCRB1zr1+8WffLFA=; b=mIypNLNpHctp4zBvj7H3Rms04S3++568fGV1X7/z0zFMKGfCrBzOqcyK y97WaVpxONn7BbZNl5OUi46AfBwUsnyOTi5kkBixN6bCk1d+9s+J2JXAr N7qYgW4ROHNWt+MLTgUD1J5a3B+WQhP6ItQGzSCZSN7WcOAA4G9bOaI2B V7QPhroEJcpDIGPEtFLJoVG0lsmjZ8CsjMLtk1w7EsvptLbXMZ60N4Qaz eI2R/N1qDJCW/wYpQ8NJ1jg6y4eFioao+0qyyn+8EkGmE13rk3+dw1ewz mvQ1KOiMhsA5iXi17rYPqWToKrT7x5IUvBrVKxqbssvGxDYKbDDuuC75b w==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="235257274" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="235257274" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 08:18:53 -0800 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="573489487" Received: from chinhtn-mobl1.amr.corp.intel.com (HELO spandruv-desk1.amr.corp.intel.com) ([10.209.26.159]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 08:18:53 -0800 Message-ID: Subject: Re: [PATCH] thermal: int340x: fix memory leak in int3400_notify() From: srinivas pandruvada To: "Rafael J. Wysocki" , Chuansheng Liu Cc: Linux Kernel Mailing List , "Zhang, Rui" Date: Tue, 22 Feb 2022 08:18:52 -0800 In-Reply-To: References: <20220222020021.19640-1-chuansheng.liu@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-02-22 at 07:42 -0800, srinivas pandruvada wrote: > On Tue, 2022-02-22 at 13:34 +0100, Rafael J. Wysocki wrote: > > Please resend this with a CC to linux-pm@vger.kernel.org.  Thanks! > > > > On Tue, Feb 22, 2022 at 3:13 AM Chuansheng Liu > > wrote: > > > > > > It is easy to hit the below memory leaks in my TigerLake > > > platform: > > > > > > -- > > > unreferenced object 0xffff927c8b91dbc0 (size 32): > > >   comm "kworker/0:2", pid 112, jiffies 4294893323 (age 83.604s) > > >   hex dump (first 32 bytes): > > >     4e 41 4d 45 3d 49 4e 54 33 34 30 30 20 54 68 65  NAME=INT3400 > > > The > > >     72 6d 61 6c 00 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  > > > rmal.kkkkkkkkkk. > > >   backtrace: > > >     [] __kmalloc_track_caller+0x2fe/0x4a0 > > >     [] kvasprintf+0x65/0xd0 > > >     [] kasprintf+0x4e/0x70 > > >     [] int3400_notify+0x82/0x120 > > > [int3400_thermal] > > >     [] acpi_ev_notify_dispatch+0x54/0x71 > > >     [] acpi_os_execute_deferred+0x17/0x30 > > >     [] process_one_work+0x21a/0x3f0 > > >     [] worker_thread+0x4a/0x3b0 > > >     [] kthread+0xfd/0x130 > > >     [] ret_from_fork+0x1f/0x30 > > > --- > > > > > > Fix it by calling kfree() accordingly. > > > > > > Signed-off-by: Chuansheng Liu > Please cc to stable Also Fixes: 38e44da59130 ("thermal: int3400_thermal: process "thermal table changed" event") > > > > --- > > >  drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 4 ++++ > > >  1 file changed, 4 insertions(+) > > > > > > diff --git > > > a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > > b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > > index 72acb1f61849..4f478812cb51 100644 > > > --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > > +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > > @@ -404,6 +404,10 @@ static void int3400_notify(acpi_handle > > > handle, > > >         thermal_prop[3] = kasprintf(GFP_KERNEL, "EVENT=%d", > > > therm_event); > > >         thermal_prop[4] = NULL; > > >         kobject_uevent_env(&priv->thermal->device.kobj, > > > KOBJ_CHANGE, thermal_prop); > > > +       kfree(thermal_prop[0]); > > > +       kfree(thermal_prop[1]); > > > +       kfree(thermal_prop[2]); > > > +       kfree(thermal_prop[3]); > > >  } > > > > > >  static int int3400_thermal_get_temp(struct thermal_zone_device > > > *thermal, > > > -- > > > 2.25.0.rc2 > > > >