Re: [PATCH v1 1/2] s390/zcrtpt: Don't leak memory if dev_set_name() fails

[Harald Freudenberger <freude@linux.ibm.com>]

On 2023-08-31 12:59, Andy Shevchenko wrote:
> When dev_set_name() fails, the zcdn_create() doesn't free
> the newly allocated resources. Do it.
> 
> Fixes: 00fab2350e6b ("s390/zcrypt: multiple zcrypt device nodes 
> support")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/s390/crypto/zcrypt_api.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/crypto/zcrypt_api.c 
> b/drivers/s390/crypto/zcrypt_api.c
> index 4b23c9f7f3e5..6b99f7dd0643 100644
> --- a/drivers/s390/crypto/zcrypt_api.c
> +++ b/drivers/s390/crypto/zcrypt_api.c
> @@ -413,6 +413,7 @@ static int zcdn_create(const char *name)
>  			 ZCRYPT_NAME "_%d", (int)MINOR(devt));
>  	nodename[sizeof(nodename) - 1] = '\0';
>  	if (dev_set_name(&zcdndev->device, nodename)) {
> +		kfree(zcdndev);
>  		rc = -EINVAL;
>  		goto unlockout;
>  	}
Thanks Andy, I picked this patch and forwarded it into the s390 
subsystem.
This will be visible in Linus' kernel tree with the next merge.