Re: [PATCH 1/6] ARM: ks8695: watchdog: stop using mach/*.h

Arnd Bergmann
2019-04-15T20:59:10Z

On Mon, Apr 15, 2019 at 10:54 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> >
> > config KS8695_WATCHDOG
> > tristate "KS8695 watchdog"
> > - depends on ARCH_KS8695
> > + depends on ARCH_KS8695 || COMPILE_TEST
>
> Is __raw_readl / __raw_writel really available for all architectures / platforms ?

I'm fairly sure it is these days, only uml and s390 used to be the
exceptions here, but they both added this.

It's possible that something else is missing, I was hoping for the 0-day
bot to tell me if so.

> > @@ -238,6 +237,11 @@ static struct miscdevice ks8695wdt_miscdev = {
> > static int ks8695wdt_probe(struct platform_device *pdev)
> > {
> > int res;
> > + struct resource *resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +
> > + tmr_reg = devm_ioremap_resource(&pdev->dev, resource);
>
> Please use devm_platform_ioremap_resource().

Ah, that is the function I was looking for, thanks for the hint.

Arnd