From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDAEAC2D0E4 for ; Wed, 18 Nov 2020 00:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92A682067D for ; Wed, 18 Nov 2020 00:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="JU/zeZ7J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727354AbgKRA2z (ORCPT ); Tue, 17 Nov 2020 19:28:55 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:17852 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbgKRA2z (ORCPT ); Tue, 17 Nov 2020 19:28:55 -0500 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AI026MJ068243; Tue, 17 Nov 2020 19:28:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=58/LN3H52j8DIj3WGK9AmtaISPCsMaXIIvoFgaSZigI=; b=JU/zeZ7JbWbTCw6JrrpHjNlYvBaNtRQfBBAyt14agwQgqfqYqSAGAWhjI8oE49rLJ+li AyxMgPCjYNhIQub/G3uPQqtwc8s24NL2FmHy4EacCWSK75vrig/pI5+5b/fQMcRXAoM5 VeJIVLvk5gYlsPL7+H3C1TGoXbWOgWtSwLNUnBwTf2tylSN44N7gem500FcuNnWg7Fkp iSs0ln+RxIGIuTCzQMoAJoxW9jqmfYx3xYnnr9WEnL+LQ+128Z0Ms7bOXLDvkMWu4MdT sbzy01DmLXgs1NjaxOMljiyt7UM8M65T4VUw+iiYdizvP9bpd8nAo+h4aNVK4OYrrnC/ 1A== Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 34vext0u6n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Nov 2020 19:28:47 -0500 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AI0SL7X003143; Wed, 18 Nov 2020 00:28:46 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma04wdc.us.ibm.com with ESMTP id 34t6v929sv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Nov 2020 00:28:46 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AI0Sjit8913498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Nov 2020 00:28:45 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5952B2805C; Wed, 18 Nov 2020 00:28:45 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14B0528059; Wed, 18 Nov 2020 00:28:43 +0000 (GMT) Received: from oc6857751186.ibm.com (unknown [9.65.230.183]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 18 Nov 2020 00:28:42 +0000 (GMT) Subject: Re: [PATCH 3/6] ibmvfc: add new fields for version 2 of several MADs To: Brian King , james.bottomley@hansenpartnership.com Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, brking@linux.ibm.com References: <20201112010442.102589-1-tyreld@linux.ibm.com> <20201112010442.102589-3-tyreld@linux.ibm.com> <5b772ce2-3119-f05b-15d3-357729e46e70@linux.vnet.ibm.com> From: Tyrel Datwyler Message-ID: Date: Tue, 17 Nov 2020 16:28:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <5b772ce2-3119-f05b-15d3-357729e46e70@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-17_15:2020-11-17,2020-11-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011170176 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/20 2:06 PM, Brian King wrote: > On 11/11/20 7:04 PM, Tyrel Datwyler wrote: >> @@ -211,7 +214,9 @@ struct ibmvfc_npiv_login_resp { >> __be64 capabilities; >> #define IBMVFC_CAN_FLUSH_ON_HALT 0x08 >> #define IBMVFC_CAN_SUPPRESS_ABTS 0x10 >> -#define IBMVFC_CAN_SUPPORT_CHANNELS 0x20 >> +#define IBMVFC_MAD_VERSION_CAP 0x20 >> +#define IBMVFC_HANDLE_VF_WWPN 0x40 >> +#define IBMVFC_CAN_SUPPORT_CHANNELS 0x80 >> __be32 max_cmds; >> __be32 scsi_id_sz; >> __be64 max_dma_len; >> @@ -293,6 +298,7 @@ struct ibmvfc_port_login { >> __be32 reserved2; >> struct ibmvfc_service_parms service_parms; >> struct ibmvfc_service_parms service_parms_change; >> + __be64 targetWWPN; > > For consistency, can you make this target_wwpn? Sure thing. > >> __be64 reserved3[2]; >> } __packed __aligned(8); >> >> @@ -344,6 +350,7 @@ struct ibmvfc_process_login { >> __be16 status; >> __be16 error; /* also fc_reason */ >> __be32 reserved2; >> + __be64 targetWWPN; > > For consistency, can you make this target_wwpn? > >> __be64 reserved3[2]; >> } __packed __aligned(8); >> >> @@ -378,6 +385,8 @@ struct ibmvfc_tmf { >> __be32 cancel_key; >> __be32 my_cancel_key; >> __be32 pad; >> + __be64 targetWWPN; > > For consistency, can you make this target_wwpn? > >> + __be64 taskTag; > > and make this task_tag. Will do. -Tyrel > >> __be64 reserved[2]; >> } __packed __aligned(8); >> >> @@ -474,9 +483,19 @@ struct ibmvfc_cmd { >> __be64 correlation; >> __be64 tgt_scsi_id; >> __be64 tag; >> - __be64 reserved3[2]; >> - struct ibmvfc_fcp_cmd_iu iu; >> - struct ibmvfc_fcp_rsp rsp; >> + __be64 targetWWPN; > > For consistency, can you make this target_wwpn? > >> + __be64 reserved3; >> + union { >> + struct { >> + struct ibmvfc_fcp_cmd_iu iu; >> + struct ibmvfc_fcp_rsp rsp; >> + } v1; >> + struct { >> + __be64 reserved4; >> + struct ibmvfc_fcp_cmd_iu iu; >> + struct ibmvfc_fcp_rsp rsp; >> + } v2; >> + }; >> } __packed __aligned(8); >> >> struct ibmvfc_passthru_fc_iu { >> @@ -503,6 +522,7 @@ struct ibmvfc_passthru_iu { >> __be64 correlation; >> __be64 scsi_id; >> __be64 tag; >> + __be64 targetWWPN; > > For consistency, can you make this target_wwpn? > >> __be64 reserved2[2]; >> } __packed __aligned(8); >> >> > >