From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528DAC43387 for ; Wed, 19 Dec 2018 22:49:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 206C520869 for ; Wed, 19 Dec 2018 22:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728781AbeLSWtP (ORCPT ); Wed, 19 Dec 2018 17:49:15 -0500 Received: from gateway36.websitewelcome.com ([192.185.187.5]:35504 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727151AbeLSWtO (ORCPT ); Wed, 19 Dec 2018 17:49:14 -0500 X-Greylist: delayed 1336 seconds by postgrey-1.27 at vger.kernel.org; Wed, 19 Dec 2018 17:49:14 EST Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 370B0400C8F70 for ; Wed, 19 Dec 2018 15:37:49 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id ZkIsghfCf90onZkIsgFiRg; Wed, 19 Dec 2018 16:26:58 -0600 X-Authority-Reason: nr=8 Received: from [189.250.106.44] (port=47198 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gZkIr-000DJt-OW; Wed, 19 Dec 2018 16:26:57 -0600 Subject: Re: [PATCH 19/41] scsi: isci: remote_node_context: mark expected switch fall-throughs To: Intel SCU Linux support , Artur Paszkiewicz Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: From: "Gustavo A. R. Silva" Message-ID: Date: Wed, 19 Dec 2018 16:26:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.106.44 X-Source-L: No X-Exim-ID: 1gZkIr-000DJt-OW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.106.44]:47198 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 22 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:30 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that, in this particular case, a dash is added as a token in > order to separate the "Fall through" annotations from the rest of > the comment on the same line, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/scsi/isci/remote_node_context.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/isci/remote_node_context.c b/drivers/scsi/isci/remote_node_context.c > index e3f2a5359d71..474a43460963 100644 > --- a/drivers/scsi/isci/remote_node_context.c > +++ b/drivers/scsi/isci/remote_node_context.c > @@ -601,9 +601,9 @@ enum sci_status sci_remote_node_context_suspend( > __func__, sci_rnc); > return SCI_FAILURE_INVALID_STATE; > } > - /* Fall through and handle like SCI_RNC_POSTING */ > + /* Fall through - and handle like SCI_RNC_POSTING */ > case SCI_RNC_RESUMING: > - /* Fall through and handle like SCI_RNC_POSTING */ > + /* Fall through - and handle like SCI_RNC_POSTING */ > case SCI_RNC_POSTING: > /* Set the destination state to AWAIT - this signals the > * entry into the SCI_RNC_READY state that a suspension >