From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980A6C43217 for ; Mon, 21 Nov 2022 15:20:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiKUPUa (ORCPT ); Mon, 21 Nov 2022 10:20:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiKUPUO (ORCPT ); Mon, 21 Nov 2022 10:20:14 -0500 Received: from out199-10.us.a.mail.aliyun.com (out199-10.us.a.mail.aliyun.com [47.90.199.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 251C6175B6; Mon, 21 Nov 2022 07:17:18 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VVOOPHM_1669043831; Received: from 30.120.171.189(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VVOOPHM_1669043831) by smtp.aliyun-inc.com; Mon, 21 Nov 2022 23:17:13 +0800 Message-ID: Date: Mon, 21 Nov 2022 23:17:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/11/21 下午6:22, John Garry 写道: > >> >> >> #./perf stat -e FRONTEND_BOUND sleep 1 >> event syntax error: 'FRONTEND_BOUND' > > For metrics, use -M, not -e > > If this doesn't help, verify generated pmu-events/pmu-events.c is same after you make the change to try to use std arch events for metrics. Note that I never tested running my change. > > Thanks, > John > >>                       \___ parser error >> Run 'perf list' for a list of valid events >> >>   Usage: perf stat [] [] >> >>      -e, --event    event selector. use 'perf list' to list available events >> >> >> >> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeli >> index f9fae15..1089ca0 100644 >> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json >> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json >> @@ -6,18 +6,24 @@ >>           "ArchStdEvent": "STALL_BACKEND" >>       }, >>       { >> -        "ArchStdEvent": "STALL_SLOT_FRONTEND" >> +        "ArchStdEvent": "STALL_SLOT_FRONTEND", >> +        "MetricExpr": "STALL_SLOT_FRONTEND - CPU_CYCLES" >>       }, >>       { >> I'm sorry that I misunderstood the purpose of putting metric as arch_std_event at first, and now it works after the modification over your suggestion. But there are also a few questions: 1. The value of the slot in the topdownL1 is various in different architectures, for example, the slot is 5 on neoverse-n2. If I put topdownL1 metric as arch_std_event, then I need to specify the slot to 5 in n2. I can specify slot values in metric like below, but is there any other concise way to do this? diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json index 8ff1dfe..b473baf 100644 --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json @@ -1,4 +1,23 @@ [ + { + "MetricExpr": "5", + "PublicDescription": "A pipeline slot represents the hardware resources needed to process one uOp", + "BriefDescription": "A pipeline slot represents the hardware resources needed to process one uOp", + "MetricName": "slot" + }, + { + "ArchStdEvent": "FRONTEND_BOUND" + }, + { + "ArchStdEvent": "BACKEND_BOUND" + }, + { + "ArchStdEvent": "WASTED" + }, + { + "ArchStdEvent": "RETIRING" + }, 2. Should I add the topdownL1 metric to tools/perf/pmu-event/recommended.json, or create a new json file to place the general metric? Looking forward to your reply. Thanks, Jing