From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Peter Zijlstra <peterz@infradead.org>, John Stultz <jstultz@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Vineeth Pillai <vineethrp@google.com>,
Sonam Sanju <sonam.sanju@intel.com>,
"Sean Christopherson" <seanjc@google.com>,
Kunwu Chan <kunwu.chan@linux.dev>, "Tejun Heo" <tj@kernel.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
Qais Yousef <qyousef@layalina.io>, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Valentin Schneider <vschneid@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Metin Kaya <Metin.Kaya@arm.com>,
Xuewen Yan <xuewen.yan94@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Suleiman Souhlal" <suleiman@google.com>,
kuyo chang <kuyo.chang@mediatek.com>, hupu <hupu.gm@gmail.com>,
<kernel-team@android.com>
Subject: Re: [PATCH v2 1/2] sched: proxy-exec: Close race causing workqueue work being delayed
Date: Wed, 6 May 2026 16:09:27 +0530 [thread overview]
Message-ID: <d909079f-761a-4312-93af-317ac048aca0@amd.com> (raw)
In-Reply-To: <20260506095343.GO1026330@noisy.programming.kicks-ass.net>
Hello Peter, John,
On 5/6/2026 3:23 PM, Peter Zijlstra wrote:
>> That said, trying to keep this full jenga tower of patches ontop of
>> both sides of your dualing banjos here is non-trivial, and I also do
>> need to get a solution for devices using the full stack on 6.18 and
>> 6.12 android trees very soon, which I'd like to keep closely aligned
>> with upstream.
Sorry about that (T_T)
>>
>> So having a clear direction to go forward would be helpful. :)
>>
>> Peter: Do you have guidance here?
>
> So yeah, I think you were feeling me right, I wanted to very much be
> able to use that is_blocked for sched_delayed too -- its always bothered
> me a little something to have to use se.sched_delayed in the core code.
We still mark the delayed task as is_blocked except we can't move the
clearing of is_blocked into ttwu_do_wakeup() just yet ...
>
> That said, I think Prateek agrees that once we get return migration into
> ttwu(), this all becomes simpler. And I think his insight that we can
> use is_blocked && !blocked_on to replace PROXY_WAKING is still valid on
> top of all that.
... and yes, with the ttwu_runnable() bits, we can cleanly do that in
ttwu_do_wakeup() when setting TASK_RUNNING.
It might also give us a neat spot for waking up the tasks attached
to the sleeping owner but I've to still wrap my head around the
locking there.
>
> Given this is all still very much an 'under construction' area, I don't
> think we need to rush fixes now. We can just slap 'BROKEN' on things and
> continue merging things for the next cycle.
Ack! We can focus on v29 and hopefully sort out everything by the
time next window rolls around and then we can tackle the dragons in
sleeping owner parts ;-)
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-05-06 10:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 21:50 [PATCH v2 0/2] Proxy Execution fixes for v7.1-rc John Stultz
2026-04-30 21:50 ` [PATCH v2 1/2] sched: proxy-exec: Close race causing workqueue work being delayed John Stultz
2026-04-30 23:53 ` John Stultz
2026-05-01 6:39 ` K Prateek Nayak
2026-05-01 7:11 ` John Stultz
2026-05-01 13:21 ` Peter Zijlstra
2026-05-01 15:55 ` K Prateek Nayak
2026-05-01 18:59 ` Peter Zijlstra
2026-05-01 22:26 ` John Stultz
2026-05-03 18:42 ` K Prateek Nayak
2026-05-04 5:37 ` K Prateek Nayak
2026-05-05 3:32 ` John Stultz
2026-05-05 4:37 ` K Prateek Nayak
2026-05-06 3:58 ` John Stultz
2026-05-06 9:53 ` Peter Zijlstra
2026-05-06 10:39 ` K Prateek Nayak [this message]
2026-05-04 21:33 ` John Stultz
2026-04-30 21:50 ` [PATCH v2 2/2] locking: mutex: Fix proxy-exec potentially deactivating tasks marked TASK_RUNNING John Stultz
2026-05-01 6:57 ` K Prateek Nayak
2026-05-04 22:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d909079f-761a-4312-93af-317ac048aca0@amd.com \
--to=kprateek.nayak@amd.com \
--cc=Metin.Kaya@arm.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=hupu.gm@gmail.com \
--cc=joelagnelf@nvidia.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@android.com \
--cc=kunwu.chan@linux.dev \
--cc=kuyo.chang@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=sonam.sanju@intel.com \
--cc=suleiman@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethrp@google.com \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox