From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B07C433E0 for ; Mon, 18 Jan 2021 18:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D44E722C9E for ; Mon, 18 Jan 2021 18:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393737AbhARStD (ORCPT ); Mon, 18 Jan 2021 13:49:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407652AbhARSrN (ORCPT ); Mon, 18 Jan 2021 13:47:13 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77F15C061573; Mon, 18 Jan 2021 10:46:33 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id h205so25453089lfd.5; Mon, 18 Jan 2021 10:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UidCJzrD1s3AVXDJyUdxsL6wVFlBwRYb0i46sQWrpls=; b=L3ZbwSzFxfsTz1EyEfOxok0FLzZ0eRcDto8duBQKohBmqsPb+2T6TMJgrmWNB0oD2o NRxjMURON1U1xetQjUJiDc4ZstPB9x4Tu04XYkm2E0vITcVuASkJDuEb2svJIfIAod/b zrg0FqPaHb23qLIXOvNLujGv+dlQA26mR5rkBy80BwRInLwoVDcWiws+2DhEo3MnWqTc SnkbzAxB3hc+MiEs5HdUhmyRIHpKMjtsww8CMSF3flsLzxKILij59MqbGMSIsXL2HbbO jJjq+7NLKnfC+8/aYk7sKqVMmcP4Uc9KfQIZ42UwXCkkMWcvsBoKcYb1dYMPJAdqfc0+ RG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UidCJzrD1s3AVXDJyUdxsL6wVFlBwRYb0i46sQWrpls=; b=Klf64EA/LtSfHSwZAEDx/uWwRZ0vHbzBDdX1hFVREQlwpph/W2K2eCMK2mYLPOzl4Y 5sFaXRQ0upRzfbeAzY31pwMHdobdkeQpjSTxexBMqtWMcGOKLY+FXsXS+20cJx3bwOXA +uWU3Jk/SM748yvNGq/FeGUnulq92bNkasWyxf0VEm/AmuzWd0lstfFF2QT5pzl4005t 6bYANG9naZ6SnsKIZpreEK+FtdRtpeqdiYq+r6eb+6Kn+nRI7N5VDyZha1F8CSEF+UeZ vHnY2/G+vV1llq6ojtyF84XNYhWBHxvcOg/zD8J2Y6bAPG+cgHb6N8NPBnjZ71UygQp9 qdHA== X-Gm-Message-State: AOAM53295zQZy16uMBGHBO2op3OSmiyweO7RqrdZix9+Lg5MlyApm0oJ a5kqkTxphdYfUbHzv0QNRc7U0wm3WJc= X-Google-Smtp-Source: ABdhPJyKl7ievkY1ZBSHBEckLW2JgrnWYAHbBqO6hoWkjId7DSctCw0+7jXcaH+tVtNY9qjfBQAybQ== X-Received: by 2002:a05:6512:612:: with SMTP id b18mr223180lfe.598.1610995591917; Mon, 18 Jan 2021 10:46:31 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id w20sm1988160lfk.67.2021.01.18.10.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 10:46:31 -0800 (PST) Subject: Re: [PATCH v3 01/12] opp: Fix adding OPP entries in a wrong order if rate is unavailable To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Peter Geis , Nicolas Chauvet , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Nishanth Menon , Yangtao Li , Matt Merhar , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20210118005524.27787-1-digetx@gmail.com> <20210118005524.27787-2-digetx@gmail.com> <20210118074416.5mjogew62fjohzlm@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Mon, 18 Jan 2021 21:46:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210118074416.5mjogew62fjohzlm@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 18.01.2021 10:44, Viresh Kumar пишет: > On 18-01-21, 03:55, Dmitry Osipenko wrote: >> Fix adding OPP entries in a wrong (opposite) order if OPP rate is >> unavailable. The OPP comparison was erroneously skipped, thus OPPs >> were left unsorted. >> >> Tested-by: Peter Geis >> Tested-by: Nicolas Chauvet >> Tested-by: Matt Merhar >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/opp/core.c | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/opp/core.c b/drivers/opp/core.c >> index dfc4208d3f87..48618ff3e99e 100644 >> --- a/drivers/opp/core.c >> +++ b/drivers/opp/core.c >> @@ -1527,12 +1527,10 @@ int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, >> mutex_lock(&opp_table->lock); >> head = &opp_table->opp_list; >> >> - if (likely(!rate_not_available)) { >> - ret = _opp_is_duplicate(dev, new_opp, opp_table, &head); >> - if (ret) { >> - mutex_unlock(&opp_table->lock); >> - return ret; >> - } >> + ret = _opp_is_duplicate(dev, new_opp, opp_table, &head); >> + if (ret) { >> + mutex_unlock(&opp_table->lock); >> + return ret; >> } >> >> list_add(&new_opp->node, head); > > Applied. Thanks. > > I am not sending it for 5.11-rc as there shouldn't be any users which > are impacted because of this right now, right ? > right