From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Suma Hegde <suma.hegde@amd.com>,
Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86/amd/hsmp: fix compile-testing without CONFiG_AMD_NB
Date: Tue, 29 Oct 2024 17:19:30 +0200 (EET) [thread overview]
Message-ID: <d93061b0-8cdf-a427-dc93-707af6282886@linux.intel.com> (raw)
In-Reply-To: <20241029151149.GMZyD7NakGOHgkEw4f@fat_crate.local>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On Tue, 29 Oct 2024, Borislav Petkov wrote:
> On Tue, Oct 29, 2024 at 02:39:41PM +0200, Ilpo Järvinen wrote:
> > I don't like this very wording because what the code very much does is
> > NULL check on node_to_amd_nb() which leads to immediate failure of
> > .probe(). (We don't call other deferences after a NULL check "NULL pointer
> > dereference" either so none is introduced by this patch, IMO.)
>
> I was wondering that too: where does this line
>
> sock->root = node_to_amd_nb(i)->root;
>
> quoted by gcc come from?
>
> IOW, what is the correct Fixes: tag?
>
> The commit 7d3135d16356 ("platform/x86/amd/hsmp: Create separate ACPI, plat and common drivers
>
> is only in next AFAICT, so I'll drop the Fixes: tag when sending...
To clarify,
The assignment line is old (from 287a821c76be8 or even before that in
some form which would have not lead to compiler warning though).
It's the COMPILE_TEST that got enabled in 7d3135d16356, before that hsmp
depended on AMD_NB so the condition could never trigger.
--
i.
next prev parent reply other threads:[~2024-10-29 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 9:23 [PATCH] platform/x86/amd/hsmp: fix compile-testing without CONFiG_AMD_NB Arnd Bergmann
2024-10-29 10:33 ` Borislav Petkov
2024-10-29 10:56 ` Arnd Bergmann
2024-10-29 11:06 ` Borislav Petkov
2024-10-29 12:40 ` Ilpo Järvinen
2024-10-29 14:11 ` Borislav Petkov
2024-10-29 15:04 ` Ilpo Järvinen
2024-10-29 12:39 ` Ilpo Järvinen
2024-10-29 15:11 ` Borislav Petkov
2024-10-29 15:19 ` Ilpo Järvinen [this message]
2024-10-29 15:59 ` Borislav Petkov
2024-10-29 17:35 ` [tip: x86/urgent] x86/amd_nb: Fix compile-testing without CONFIG_AMD_NB tip-bot2 for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d93061b0-8cdf-a427-dc93-707af6282886@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=suma.hegde@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox