From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57DEC35280 for ; Fri, 8 May 2020 01:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8517207DD for ; Fri, 8 May 2020 01:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726815AbgEHBGQ (ORCPT ); Thu, 7 May 2020 21:06:16 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3903 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726509AbgEHBGP (ORCPT ); Thu, 7 May 2020 21:06:15 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 6BF86FCECC25D483787D; Fri, 8 May 2020 09:06:13 +0800 (CST) Received: from [127.0.0.1] (10.166.212.180) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 8 May 2020 09:06:09 +0800 Subject: Re: [PATCH -next] dm mpath: Remove unused variable ret To: Mike Snitzer CC: , , References: <1588854412-19301-1-git-send-email-zou_wei@huawei.com> <20200507142958.GA12032@redhat.com> From: Samuel Zou Message-ID: Date: Fri, 8 May 2020 09:06:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200507142958.GA12032@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.166.212.180] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike, You are right. I did not notice that the macro DMEMIT uses the sz variable. Thanks. On 2020/5/7 22:29, Mike Snitzer wrote: > On Thu, May 07 2020 at 8:26am -0400, > Samuel Zou wrote: > >> This patch fixes below warning reported by coccicheck: >> >> drivers/md/dm-historical-service-time.c:240:14-16: Unneeded variable: "sz". Return "0" on line 261 >> >> Reported-by: Hulk Robot >> Signed-off-by: Samuel Zou > > Nack. > > DMEMIT() uses the local sz variable. > >