From: Krzysztof Kozlowski <krzk@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] soc: samsung: exynos-pmu: fix device leak on regmap lookup
Date: Thu, 27 Nov 2025 16:55:23 +0100 [thread overview]
Message-ID: <d94f40f7-9daf-46a0-bf60-c59e935ece1e@kernel.org> (raw)
In-Reply-To: <aSB_VoKvDUHDbNDb@hovoldconsulting.com>
On 21/11/2025 16:03, Johan Hovold wrote:
> On Fri, Nov 21, 2025 at 01:59:59PM +0100, Krzysztof Kozlowski wrote:
>> On 21/11/2025 13:18, Johan Hovold wrote:
>>> Make sure to drop the reference taken when looking up the PMU device and
>>> its regmap.
>>>
>>> Note that holding a reference to a device does not prevent its regmap
>>> from going away so there is no point in keeping the reference.
>
>>> Fixes: 0b7c6075022c ("soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs")
>>> Cc: stable@vger.kernel.org # 6.9
>>
>> Fix is fine, but unfortunately the code in v6.9 was different and I
>> believe keeping dev reference made sense there - driver was relying on
>> drvdata. While the leak was there as well, it was intentional. I think
>> the leak can be fixed only since commit
>> 35d6b98c625867209bc47df99cf03edf4280799f .
>
> It makes no difference actually as holding a reference to a device does
> not prevent its driver data from going away either.
True, fair enough.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-27 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 12:18 [PATCH] soc: samsung: exynos-pmu: fix device leak on regmap lookup Johan Hovold
2025-11-21 12:59 ` Krzysztof Kozlowski
2025-11-21 15:03 ` Johan Hovold
2025-11-27 15:55 ` Krzysztof Kozlowski [this message]
2025-11-27 15:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d94f40f7-9daf-46a0-bf60-c59e935ece1e@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox