Re: [PATCH 2/2] arm64: dts: qcom: sm8150: Add support for Xiaomi Redmi K20 Pro

Konrad Dybcio
2025-10-29T09:06:56Z

On 10/28/25 5:13 PM, Piyush Raj Chouhan wrote:
> Hi, konrad
>
>
>>> +
>>> +&i2c19 {
>>> + /* goodix,gt9886 @5d */
>>
>> I see there's driver support for the GT98*97* - is there a chance you can
>> reuse some of it?
>>
>
> I am currently testing touch on gtx8 driver which currently is in lkml, once its merged we could add support for it.
>
> https://lore.kernel.org/linux-input/20250918-gtx8-v1-0-cba879c84775@mainlining.org

That's great!

[...]

>>> + led@2 {
>>> + reg = <2>;
>>> + color = <LED_COLOR_ID_RED>;
>>> + function = LED_FUNCTION_STATUS;
>>> + function-enumerator = <0>;
>>> + };
>>> +
>>> + led@3 {
>>> + reg = <3>;
>>> + color = <LED_COLOR_ID_RED>;
>>> + function = LED_FUNCTION_STATUS;
>>> + function-enumerator = <1>;
>>> + };
>>
>> Are there really two separate red LEDs?
>
> Yes, it has popup camera with an LED on both side, i have verified functionality of both LEDs.

OK, would you mind adding a label= entry with perhaps "Pop-up camera
front/back"?

Konrad