From: Dmitry Osipenko <digetx@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>,
robh+dt@kernel.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, mperttunen@nvidia.com,
ldewangan@nvidia.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] i2c: tegra: Add support for Tegra234 I2C
Date: Tue, 18 Jan 2022 23:54:14 +0300 [thread overview]
Message-ID: <d9a21970-b403-4674-dbd6-5dfab0a83a3b@gmail.com> (raw)
In-Reply-To: <1642080623-15980-2-git-send-email-akhilrajeev@nvidia.com>
13.01.2022 16:30, Akhil R пишет:
> +static const struct tegra_i2c_hw_feature tegra234_i2c_hw = {
> + .has_continue_xfer_support = true,
> + .has_per_pkt_xfer_complete_irq = true,
> + .clk_divisor_hs_mode = 0x2,
> + .clk_divisor_std_mode = 0x4f,
> + .clk_divisor_fast_mode = 0x58,
> + .clk_divisor_fast_plus_mode = 0x24,
> + .has_config_load_reg = true,
> + .has_multi_master_mode = true,
> + .has_slcg_override_reg = true,
> + .has_mst_fifo = true,
> + .quirks = &tegra194_i2c_quirks,
> + .supports_bus_clear = true,
> + .has_apb_dma = false,
> + .tlow_std_mode = 0x8,
> + .thigh_std_mode = 0x7,
> + .tlow_fast_fastplus_mode = 0x1,
> + .thigh_fast_fastplus_mode = 0x1,
> + .setup_hold_time_std_mode = 0x08080808,
> + .setup_hold_time_fast_fast_plus_mode = 0x02020202,
> + .setup_hold_time_hs_mode = 0x090909,
> + .has_interface_timing_reg = true,
> +};
Why tegra194_i2c_hw can't be reused by T234? Looks like I2C h/w hasn't
changed and somebody just made a minor tuning of the timing parameters,
does it really matter in practice?
next prev parent reply other threads:[~2022-01-18 20:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 13:30 [PATCH 0/6] Add I2C and PWM support for T234 Akhil R
2022-01-13 13:30 ` [PATCH 1/6] i2c: tegra: Add support for Tegra234 I2C Akhil R
2022-01-18 20:54 ` Dmitry Osipenko [this message]
2022-01-19 8:20 ` Akhil R
2022-01-19 12:20 ` Dmitry Osipenko
2022-01-20 14:23 ` Akhil R
2022-01-13 13:30 ` [PATCH 2/6] dt-bindings: i2c: tegra: Add Tegra234 details Akhil R
2022-02-09 2:17 ` Rob Herring
2022-02-09 3:54 ` Akhil R
2022-01-13 13:30 ` [PATCH 3/6] dt-bindings: Add headers for Tegra234 I2C Akhil R
2022-01-13 13:30 ` [PATCH 4/6] arm64: tegra: Add Tegra234 I2C devicetree nodes Akhil R
2022-01-13 13:30 ` [PATCH 5/6] dt-bindings: Add headers for Tegra234 PWM Akhil R
2022-01-13 13:30 ` [PATCH 6/6] arm64: tegra: Add Tegra234 PWM devicetree nodes Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a21970-b403-4674-dbd6-5dfab0a83a3b@gmail.com \
--to=digetx@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox