From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@suse.com>, Nico Pache <npache@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, shakeelb@google.com,
ktkhai@virtuozzo.com, shy828301@gmail.com, guro@fb.com,
vbabka@suse.cz, vdavydov.dev@gmail.com, raquini@redhat.com
Subject: Re: [RFC PATCH 2/2] mm/vmscan.c: Prevent allocating shrinker_info on offlined nodes
Date: Mon, 6 Dec 2021 11:45:54 +0100 [thread overview]
Message-ID: <d9d14beb-ee20-7ebb-e007-fbf58fb28535@redhat.com> (raw)
In-Reply-To: <Ya3WcYKcej8XEI0W@dhcp22.suse.cz>
> This doesn't seen complete. Slab shrinkers are used in the reclaim
> context. Previously offline nodes could be onlined later and this would
> lead to NULL ptr because there is no hook to allocate new shrinker
> infos. This would be also really impractical because this would have to
> update all existing memcgs...
Instead of going through the trouble of updating...
... maybe just keep for_each_node() and check if the target node is
offline. If it's offline, just allocate from the first online node.
After all, we're not using __GFP_THISNODE, so there are no guarantees
either way ...
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-12-06 10:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 3:33 [RFC PATCH 0/2] mm: Dont allocate pages on a offline node Nico Pache
2021-12-06 3:33 ` [RFC PATCH 1/2] include/linux/gfp.h: Do not allocate pages on a offlined node Nico Pache
2021-12-06 3:37 ` Matthew Wilcox
2021-12-06 8:29 ` David Hildenbrand
2021-12-06 9:22 ` Michal Hocko
2021-12-07 21:24 ` Nico Pache
2021-12-06 3:33 ` [RFC PATCH 2/2] mm/vmscan.c: Prevent allocating shrinker_info on offlined nodes Nico Pache
2021-12-06 8:32 ` David Hildenbrand
2021-12-06 9:22 ` Michal Hocko
2021-12-06 9:24 ` Michal Hocko
2021-12-06 10:45 ` David Hildenbrand [this message]
2021-12-06 10:54 ` Michal Hocko
2021-12-06 11:00 ` David Hildenbrand
2021-12-06 11:22 ` Michal Hocko
2021-12-06 12:43 ` David Hildenbrand
2021-12-06 13:06 ` Michal Hocko
2021-12-06 13:47 ` David Hildenbrand
2021-12-06 14:06 ` Michal Hocko
2021-12-06 14:08 ` David Hildenbrand
2021-12-06 14:21 ` Michal Hocko
2021-12-06 14:30 ` Vlastimil Babka
2021-12-06 14:53 ` Michal Hocko
2021-12-06 18:26 ` Yang Shi
2021-12-07 10:15 ` Michal Hocko
2021-12-06 14:15 ` Michal Hocko
2021-12-06 13:19 ` Kirill Tkhai
2021-12-06 13:24 ` Michal Hocko
2021-12-08 19:00 ` Nico Pache
2021-12-06 18:42 ` Yang Shi
2021-12-06 19:01 ` David Hildenbrand
2021-12-06 21:28 ` Yang Shi
2021-12-07 10:15 ` David Hildenbrand
2021-12-07 10:55 ` Michal Hocko
2021-12-07 21:45 ` Nico Pache
2021-12-07 21:40 ` Nico Pache
2021-12-07 21:34 ` Nico Pache
2021-12-06 18:45 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d14beb-ee20-7ebb-e007-fbf58fb28535@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=raquini@redhat.com \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox