From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A86BC83F3F for ; Mon, 4 Sep 2023 07:37:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351547AbjIDHhB (ORCPT ); Mon, 4 Sep 2023 03:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352439AbjIDHg7 (ORCPT ); Mon, 4 Sep 2023 03:36:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64931138 for ; Mon, 4 Sep 2023 00:36:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEBD161231 for ; Mon, 4 Sep 2023 07:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EA17C433C8; Mon, 4 Sep 2023 07:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693813014; bh=1kEqDO+Le0/vd5hsx9Tq9iF6mUzLlU0yolPMHIZIPl0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=Hyc+AdqHrJ762BvgfQcGmZcibW8ab+UpNM85RE5MY8vbO0DiUI7HN4es6MbLGK7Ba Jm3+jZmyQKeuaimVoGBkZgJz7dAQ3PjCIY3jgRcBFPtBPo3Ed3xXFCp1qnZsqkiJJh VL0gWbkmPOqPy0mW9QRUsyGG/shEM6P5neuu4VQOrETl1waqcbosGVB2Hlrdfff2TB PJSeSqOa9QyYwd0YOyU638/1M58nlCyaQcyLJ7XH4pyRGQLZ+T3XGJvNhbMEZF1SIs fh2meoyexKImRKBKQ1owzpSqFPzrUUpTxkco1sdijx754GP2uCwoF12J73P589eCi5 tzkzU3H3r+nrA== Message-ID: Date: Mon, 04 Sep 2023 07:36:51 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 02/15] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time In-Reply-To: <20230901164111.RFT.2.I134336fce7eac5a63bdac46d57b0888858fc8081@changeid> References: <20230901164111.RFT.2.I134336fce7eac5a63bdac46d57b0888858fc8081@changeid> Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, festevam@gmail.com, kernel@pengutronix.de, l.stach@pengutronix.de, laurentiu.palcu@oss.nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, shawnguo@kernel.org, "Maxime Ripard" , "Sascha Hauer" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Sep 2023 16:41:13 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered off at system shutdown time. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime