public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Breno Leitao <leitao@debian.org>, Ard Biesheuvel <ardb@kernel.org>
Cc: Usama Arif <usamaarif642@gmail.com>,
	linux-efi@vger.kernel.org,  kexec@lists.infradead.org,
	ebiederm@xmission.com, bhe@redhat.com,  vgoyal@redhat.com,
	tglx@linutronix.de, dave.hansen@linux.intel.com, x86@kernel.org,
	 linux-kernel@vger.kernel.org, rmikey@meta.com,
	gourry@gourry.net
Subject: Re: [RFC] efi/tpm: add efi.tpm_log as a reserved region in 820_table_firmware
Date: Thu, 12 Sep 2024 12:22:01 -0400	[thread overview]
Message-ID: <d9df5012cd3306afa2eddd5187e643a3bbdfd866.camel@HansenPartnership.com> (raw)
In-Reply-To: <20240912-wealthy-gabby-tamarin-aaba3c@leitao>

On Thu, 2024-09-12 at 06:03 -0700, Breno Leitao wrote:
> Hello Ard,
> 
> On Thu, Sep 12, 2024 at 12:51:57PM +0200, Ard Biesheuvel wrote:
> > I don't see how this could be an EFI bug, given that it does not
> > deal with E820 tables at all.
> 
> I want to back up a little bit and make sure I am following the
> discussion.
> 
> From what I understand from previous discussion, we have an EFI bug
> as the root cause of this issue.
> 
> This happens because the EFI does NOT mark the EFI TPM event log
> memory region as reserved (EFI_RESERVED_TYPE). Not having an entry
> for the event table memory in EFI memory mapped, then libstub will
> ignore it completely (the TPM event log memory range) and not
> populate e820 table with it.

Wait, that's not correct.  The TPM log is in memory that doesn't
survive ExitBootServices (by design in case the OS doesn't care about
it).  So the EFI stub actually copies it over to a new configuration
table that is in reserved memory before it calls ExitBootServices. 
This new copy should be in kernel reserved memory regardless of its
e820 map status.

Regards,

James


  parent reply	other threads:[~2024-09-12 16:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 10:41 [RFC] efi/tpm: add efi.tpm_log as a reserved region in 820_table_firmware Usama Arif
2024-09-11 11:51 ` Ard Biesheuvel
2024-09-11 14:34   ` Usama Arif
2024-09-12 10:23   ` Usama Arif
2024-09-12 10:51     ` Ard Biesheuvel
2024-09-12 11:17       ` Usama Arif
2024-09-12 13:03       ` Breno Leitao
2024-09-12 13:10         ` Ard Biesheuvel
2024-09-12 13:54           ` Usama Arif
2024-09-12 14:05             ` Ard Biesheuvel
2024-09-12 14:14               ` Ard Biesheuvel
2024-09-13 10:56                 ` Dave Young
2024-09-13 11:06                   ` Usama Arif
2024-09-13 11:13                     ` Dave Young
2024-09-13 11:49                       ` Dave Young
2024-09-13 11:56                         ` Usama Arif
2024-09-13 12:52                           ` Dave Young
2024-09-14  6:46                   ` Dave Young
2024-09-14  8:31                     ` Ard Biesheuvel
2024-09-14  9:24                       ` Dave Young
2024-09-14  9:46                         ` Dave Young
2024-09-12 14:29           ` Breno Leitao
2024-09-12 15:21             ` Ard Biesheuvel
2024-09-12 15:35               ` Usama Arif
2024-09-12 15:45                 ` Ard Biesheuvel
2024-09-12 16:22         ` James Bottomley [this message]
2024-09-13 11:57           ` Breno Leitao
2024-09-13 12:07             ` James Bottomley
2024-09-16 20:20               ` Eric W. Biederman
2024-09-17  6:45                 ` Ard Biesheuvel
2024-09-17 15:24                   ` Eric W. Biederman
2024-09-17 15:35                     ` Ard Biesheuvel
2024-09-18  3:13                       ` Eric W. Biederman
2024-09-18  7:36                         ` Ard Biesheuvel
2024-10-09  9:10                           ` Jonathan McDowell
2024-10-09 10:46                             ` Breno Leitao
2024-10-09 14:05                               ` Jonathan McDowell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9df5012cd3306afa2eddd5187e643a3bbdfd866.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=ardb@kernel.org \
    --cc=bhe@redhat.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=ebiederm@xmission.com \
    --cc=gourry@gourry.net \
    --cc=kexec@lists.infradead.org \
    --cc=leitao@debian.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmikey@meta.com \
    --cc=tglx@linutronix.de \
    --cc=usamaarif642@gmail.com \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox