From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95385C43334 for ; Mon, 27 Jun 2022 18:52:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240319AbiF0Swh (ORCPT ); Mon, 27 Jun 2022 14:52:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240243AbiF0Swe (ORCPT ); Mon, 27 Jun 2022 14:52:34 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 623BDEB9 for ; Mon, 27 Jun 2022 11:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656355953; x=1687891953; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=A7ztOuMqK8/tvFrlCEBcCLu71GhWrpbUZrN88Eif/Dg=; b=igx6RM+Cr13r97Jtm/SEUmPojG3g+7+5PHBr/ttfj5KKBxzyfGSXOGaM yWc49JYu4dsslrEkgS3XyU1BUuP29wvm+oaU/S/hMLnl81Wrqtd3HA9iD xtdhXUiKOuqFf4WOwt6/H5kVJwcdKUKaCioShvGeMjaU+vsRMnRdvaRzw w+BNZ3mKsesBM1ZQTSUsK3gAV1Y7EoOR5kbGYqQaWqhDLGT2+N5noI6XG Fv1TQL2UYUdRCQvvvA/vkhzqBK/NmQ5sgrlBgvnMSwo8v4O40Nl9aTDuA pRI31GuF7CpY6U47Mog6mdUTX1hZENy7S/rvhExzWrbYjYcsR8KWof4j1 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="343224095" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="343224095" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 11:52:32 -0700 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="732439707" Received: from jsagoe-mobl1.amr.corp.intel.com (HELO [10.209.12.66]) ([10.209.12.66]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 11:52:31 -0700 Message-ID: Date: Mon, 27 Jun 2022 11:51:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v8 0/5] Add TDX Guest Attestation support Content-Language: en-US To: Sathyanarayanan Kuppuswamy , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org Cc: "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org References: <20220609025220.2615197-1-sathyanarayanan.kuppuswamy@linux.intel.com> <9abde78c-d2c5-c762-24fe-f26669b7cc6c@intel.com> <2502d21b-8f27-ebe5-b677-4cc56b03ee2c@linux.intel.com> From: Dave Hansen In-Reply-To: <2502d21b-8f27-ebe5-b677-4cc56b03ee2c@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/27/22 07:51, Sathyanarayanan Kuppuswamy wrote: > In TDX guest, attestation process generally involves the following steps: > > 1. Get the TDREPORT using user specified REPORTDATA. This is implemented >    using TDG.MR.TDREPORT Module call. An IOCTL interface is added to let >    userspace get the TDREPORT data  (implemented in patch #1). >     > 2. Using the TDREPORT data, generate a remotely verifiable signed Quote. >    Quote can be generated either using GetQuote hypercall or by communicating >    with VMM/Quoting Enclave(QE) using VSOCK. In this patch set, only the > GetQuote hypercall model is supported. Since Quote generation is an > asynchronous request, and takes more time, we let VMM notify the TDX Guest > using the callback interrupt. Patch # 2-5 implements Quote generation support, > in which Patch # 2 implements the callback interrupt support. IMNHO, too much gibberish, not enough English, too much superfluous information. For instance, why do we need a quote and a report? Why does this have an interrupt?