From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>, wangshuaijie@awinic.com
Cc: waqar.hameed@axis.com, liweilei@awinic.com, lars@metafoo.de,
linux-iio@vger.kernel.org, kangjiajun@awinic.com,
jic23@kernel.org, linux-kernel@vger.kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH V4 1/2] dt-bindings: iio: aw9610x: Add bindings for aw9610x sensor
Date: Thu, 25 Jul 2024 15:54:10 +0200 [thread overview]
Message-ID: <d9e0e87c-0332-48b3-879d-258ca0fe58ee@kernel.org> (raw)
In-Reply-To: <172191345400.1572973.8660057237993091930.robh@kernel.org>
On 25/07/2024 15:17, Rob Herring (Arm) wrote:
>
> On Thu, 25 Jul 2024 12:12:51 +0000, wangshuaijie@awinic.com wrote:
>> From: shuaijie wang <wangshuaijie@awinic.com>
>>
>> Add device tree bindings for aw9610x proximity sensor.
>>
>> Signed-off-by: shuaijie wang <wangshuaijie@awinic.com>
>> ---
>> .../iio/proximity/awinic,aw9610x.yaml | 61 +++++++++++++++++++
>> 1 file changed, 61 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
> $id: http://devicetree.org/schemas/input/awinic,aw9610x.yaml
> file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml
Look, still not tested.
You got comment on v3 that you must it prior to sending. The comment
also explained how to perform the testing.
You responded that you will implement testing but as easily we can see
here, you still did not test it.
Please, stop wasting our time. TEST your patches BEFORE sending.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-25 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 12:12 [PATCH V4 0/2] Add support for aw9610x proximity sensor wangshuaijie
2024-07-25 12:12 ` [PATCH V4 1/2] dt-bindings: iio: aw9610x: Add bindings for aw9610x sensor wangshuaijie
2024-07-25 13:17 ` Rob Herring (Arm)
2024-07-25 13:54 ` Krzysztof Kozlowski [this message]
2024-07-26 6:12 ` wangshuaijie
2024-07-25 12:12 ` [PATCH V4 2/2] iio: proximity: aw9610x: Add support for aw9610x proximity sensor wangshuaijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e0e87c-0332-48b3-879d-258ca0fe58ee@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kangjiajun@awinic.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=robh@kernel.org \
--cc=wangshuaijie@awinic.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox