From: Michal Wilczynski <m.wilczynski@samsung.com>
To: Arnd Bergmann <arnd@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Drew Fustini <drew@pdp7.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Guillaume La Roque <glaroque@baylibre.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Prasad Pandit <pjp@fedoraproject.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: thead: add CONFIG_MAILBOX dependency
Date: Fri, 14 Mar 2025 17:39:19 +0100 [thread overview]
Message-ID: <d9f3b44e-a1f7-4441-a731-ea99990de871@samsung.com> (raw)
In-Reply-To: <20250314154816.4045334-1-arnd@kernel.org>
On 3/14/25 16:48, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this, the driver fails to build:
>
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_call_rpc':
> thead,th1520-aon.c:(.text+0x28): undefined reference to `mbox_send_message'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_deinit':
> thead,th1520-aon.c:(.text+0x17e): undefined reference to `mbox_free_channel'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_init':
> thead,th1520-aon.c:(.text+0x1d9): undefined reference to `mbox_request_channel_byname'
>
> Fixes: e4b3cbd840e5 ("firmware: thead: Add AON firmware protocol driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/firmware/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 42e3dd1c387a..6ab9f7ca7ff1 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -239,6 +239,7 @@ config SYSFB_SIMPLEFB
> config TH1520_AON_PROTOCOL
> tristate "Always-On firmware protocol"
> depends on ARCH_THEAD || COMPILE_TEST
> + depends on MAILBOX
> help
> Power, clock, and resource management capabilities on the TH1520 SoC are
> managed by the E902 core. Firmware running on this core communicates with
Thanks, looks good shouldn't have missed that.
Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
next prev parent reply other threads:[~2025-03-14 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250314154826eucas1p20139736cab789432ed0884b020eec244@eucas1p2.samsung.com>
2025-03-14 15:48 ` [PATCH] firmware: thead: add CONFIG_MAILBOX dependency Arnd Bergmann
2025-03-14 16:39 ` Michal Wilczynski [this message]
2025-03-18 12:14 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9f3b44e-a1f7-4441-a731-ea99990de871@samsung.com \
--to=m.wilczynski@samsung.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=drew@pdp7.com \
--cc=glaroque@baylibre.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjp@fedoraproject.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox