From: Jeff Layton <jlayton@kernel.org>
To: Thorsten Blum <thorsten.blum@toblux.com>,
trondmy@kernel.org, anna@kernel.org
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Coddington <bcodding@redhat.com>
Subject: Re: [RESEND PATCH] nfs: Remove unnecessary NULL check before kfree()
Date: Tue, 10 Sep 2024 07:48:47 -0400 [thread overview]
Message-ID: <d9f643b8a56f870dc757ad9727bf0d543bc2ff99.camel@kernel.org> (raw)
In-Reply-To: <20240910104208.4536-2-thorsten.blum@toblux.com>
On Tue, 2024-09-10 at 12:42 +0200, Thorsten Blum wrote:
> Since kfree() already checks if its argument is NULL, an additional
> check before calling kfree() is unnecessary and can be removed.
>
> Remove it and thus also the following Coccinelle/coccicheck warning
> reported by ifnullfree.cocci:
>
> WARNING: NULL check before some freeing functions is not needed
>
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> fs/nfs/read.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfs/read.c b/fs/nfs/read.c
> index a6103333b666..81bd1b9aba17 100644
> --- a/fs/nfs/read.c
> +++ b/fs/nfs/read.c
> @@ -48,8 +48,7 @@ static struct nfs_pgio_header *nfs_readhdr_alloc(void)
>
> static void nfs_readhdr_free(struct nfs_pgio_header *rhdr)
> {
> - if (rhdr->res.scratch != NULL)
> - kfree(rhdr->res.scratch);
> + kfree(rhdr->res.scratch);
> kmem_cache_free(nfs_rdata_cachep, rhdr);
> }
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-09-10 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 10:42 [RESEND PATCH] nfs: Remove unnecessary NULL check before kfree() Thorsten Blum
2024-09-10 11:48 ` Jeff Layton [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-01 16:19 Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9f643b8a56f870dc757ad9727bf0d543bc2ff99.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=thorsten.blum@toblux.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox