From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9F1C33CAF for ; Sun, 19 Jan 2020 04:21:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C98C20679 for ; Sun, 19 Jan 2020 04:21:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tn6v5ucg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726590AbgASEVq (ORCPT ); Sat, 18 Jan 2020 23:21:46 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:52196 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgASEVq (ORCPT ); Sat, 18 Jan 2020 23:21:46 -0500 Received: by mail-pj1-f65.google.com with SMTP id d15so5098561pjw.1 for ; Sat, 18 Jan 2020 20:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:autocrypt:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=szD+KEp5JMedpU/ESl+XBAVyw+4cZyi4d3383NhKcEk=; b=tn6v5ucgfbp4MHdl7WHTRyMQmuFcENyb+iPbHtmVGDvDFGkkQfye1MHrLV41KbtaG5 UDLd7upvW/wDGFkcQCWOubQKZcImzuUGu4H+zbRyw+AMnSkADGjZX1Z6wZnmqzzbl+K1 hq0o0iKV3Wr6Y9y4UUVeSKA8yrFb7Uzm3r1ZZUw454P0ChZ/4uf5piSVpBVlimT2Axza VkO/zCzvFzUzLuEUF2tUqT3U5naKGKl1nsdozMsdCjNFevop3UIEn+UJSR0PhwiyWdgH pIQgRHXUeHifyK4Bl/CVxlCn9bLgRZSw8vDsnaVmDpB3/VRc4QI2Rpas5Qu0Cqegifoz 4dwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:autocrypt:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=szD+KEp5JMedpU/ESl+XBAVyw+4cZyi4d3383NhKcEk=; b=sOFq+EMW4WXf7jh/YND1k5EBhJt2iZ+wHvtC94BN791VGLkEN4mQazHhPCWMo0dfwD qUti4/1vKe9rlqTNdXknevLflc76i8U/iYy+Px+BIXHvxoHl1mScDagHMW7feBp6wW9d yedWeScsd11cvHzM96Cah0wTNxzIPdoWBPxie7vaBzba6U0u5bCLYeAWi4mLr3rxchvq 3snAjAuve1rPpLyfDTHadXevu+QZYsyhczPUuPIhWVLJ7rKFStJfy22cnS/jw7cOLQ5/ P5JYkThgP0rem+PEkFovr/s+EMOhBGHCGJhijGHXb0Kzbj3P89H1qqVTW+NBKH0QQSqt U7pg== X-Gm-Message-State: APjAAAWsEXeJe/IOFgSQncl5Ldr3whLjb3zNI8WbYdGZNubjHmTQ2WgU h6KMNLzUOhLmWVbnTBqdiRg= X-Google-Smtp-Source: APXvYqxCf1YLgNXGcV/+cDdab1Lj7iswVdpX/5C8MLJCDCrx6CiejLpybBQJz/R16U9jciGIV/giMQ== X-Received: by 2002:a17:90a:ead3:: with SMTP id ev19mr15877949pjb.80.1579407705103; Sat, 18 Jan 2020 20:21:45 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id b42sm5443106pjc.27.2020.01.18.20.21.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2020 20:21:44 -0800 (PST) To: Gregory Clement , mripard@kernel.org, Chen-Yu Tsai , Linux Kernel Mailing List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" From: Florian Fainelli Subject: No master_xfer_atomic for i2c-mv64xxx.c Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: Date: Sat, 18 Jan 2020 20:21:43 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Gregory, Maxime, Chen-Yu, Happy new year to all of you! On a lamobo R1 (A20) the trace below can be seen by typing "halt" which makes us try to perform an i2c transaction in atomic context by the X-powers AXP20x driver while the i2c-mv64xxx.c driver does not support it. I am not familiar enough with this i2c controller to suggest a way to refactor it such that it would easily gain master_xfer_atomic support. Is this something you could look at? Thanks! [ 1617.999014] reboot: Power down [ 1618.002111] ------------[ cut here ]------------ [ 1618.006752] WARNING: CPU: 0 PID: 2427 at drivers/i2c/i2c-core.h:41 i2c_transfer+0x108/0x144 [ 1618.015092] No atomic I2C transfer handler for 'i2c-0' [ 1618.020222] Modules linked in: pppoe ppp_async pppox ppp_generic slhc crc_ccitt cmac [ 1618.027987] CPU: 0 PID: 2427 Comm: procd Not tainted 5.5.0-rc5+ #0 [ 1618.034158] Hardware name: Allwinner sun7i (A20) Family [ 1618.039376] Backtrace: [ 1618.041837] [] (dump_backtrace) from [] (show_stack+0x20/0x24) [ 1618.049400] r7:00000029 r6:60000093 r5:00000000 r4:c10a197c [ 1618.055061] [] (show_stack) from [] (dump_stack+0x9c/0xb0) [ 1618.062282] [] (dump_stack) from [] (__warn+0xe0/0x108) [ 1618.069237] r7:00000029 r6:00000009 r5:c075d948 r4:c0aefafc [ 1618.074895] [] (__warn) from [] (warn_slowpath_fmt+0x94/0x9c) [ 1618.082369] r7:c075d948 r6:00000029 r5:c0aefafc r4:c0aefbc0 [ 1618.088026] [] (warn_slowpath_fmt) from [] (i2c_transfer+0x108/0x144) [ 1618.096195] r8:00000032 r7:c10a93e4 r6:00000001 r5:ea32fd3c r4:ea945ca8 [ 1618.102892] [] (i2c_transfer) from [] (i2c_transfer_buffer_flags+0x4c/0x5c) [ 1618.111579] r6:eb3c6501 r5:00000001 r4:00000002 [ 1618.116199] [] (i2c_transfer_buffer_flags) from [] (regmap_i2c_write+0x24/0x40) [ 1618.125229] r4:00000002 [ 1618.127768] [] (regmap_i2c_write) from [] (_regmap_raw_write_impl+0x72c/0x908) [ 1618.136713] r5:00000001 r4:ea8d9c00 [ 1618.140291] [] (_regmap_raw_write_impl) from [] (_regmap_bus_raw_write+0x7c/0xa0) [ 1618.149501] r10:00000058 r9:ea32e000 r8:fee1dead r7:00000080 r6:00000032 r5:c066be98 [ 1618.157319] r4:ea8d9c00 [ 1618.159857] [] (_regmap_bus_raw_write) from [] (_regmap_write+0x7c/0x164) [ 1618.168371] r7:ea8d9c00 r6:00000080 r5:00000032 r4:ea8d9c00 [ 1618.174029] [] (_regmap_write) from [] (regmap_write+0x4c/0x6c) [ 1618.181679] r9:ea32e000 r8:fee1dead r7:0002e574 r6:00000080 r5:00000032 r4:ea8d9c00 [ 1618.189420] [] (regmap_write) from [] (axp20x_power_off+0x3c/0x48) [ 1618.197328] r7:0002e574 r6:28121969 r5:c1004e90 r4:4321fedc [ 1618.202985] [] (axp20x_power_off) from [] (machine_power_off+0x34/0x38) [ 1618.211332] [] (machine_power_off) from [] (kernel_power_off+0x7c/0x80) [ 1618.219676] [] (kernel_power_off) from [] (__do_sys_reboot+0x190/0x1f4) [ 1618.228019] [] (__do_sys_reboot) from [] (sys_reboot+0x18/0x1c) [ 1618.235669] r8:c0201324 r7:00000058 r6:b6f69010 r5:becbbe2c r4:00000000 [ 1618.242366] [] (sys_reboot) from [] (ret_fast_syscall+0x0/0x4c) [ 1618.250013] Exception stack(0xea32ffa8 to 0xea32fff0) [ 1618.255062] ffa0: 00000000 becbbe2c fee1dead 28121969 4321fedc 0002e574 [ 1618.263231] ffc0: 00000000 becbbe2c b6f69010 00000058 ffffffff 00000000 0000201d 00000001 [ 1618.271398] ffe0: 0002de54 becbbd5c 0001ac8c b6f8e408 [ 1618.276443] ---[ end trace 526da779414c6638 ]--- -- Florian