Re: [PATCH v12 2/3] iio: adc: max14001: New driver

[David Lechner <dlechner@baylibre.com>]

On 10/5/25 6:25 PM, Marilene Andrade Garcia wrote:
> On 01/10/2025 11:03, David Lechner wrote:
>> On Mon, Sep 29, 2025 at 7:59 AM Marilene Andrade Garcia
>> <marilene.agarcia@gmail.com> wrote:
>>>
>>
> ...
>>> +static int max14001_read_raw(struct iio_dev *indio_dev,
>>> +                            struct iio_chan_spec const *chan,
>>> +                            int *val, int *val2, long mask)
>>> +{
>>> +       struct max14001_state *st = iio_priv(indio_dev);
>>> +       int ret;
>>> +
>>> +       switch (mask) {
>>> +       case IIO_CHAN_INFO_RAW:
>>> +               ret = regmap_read(st->regmap, MAX14001_REG_ADC, val);
>>> +               if (ret)
>>> +                       return ret;
>>> +
>>> +               return IIO_VAL_INT;
>>> +       case IIO_CHAN_INFO_AVERAGE_RAW:
>>> +               ret = regmap_read(st->regmap, MAX14001_REG_FADC, val);
>>
>> I don't remember... did you give a reason why this should not be a
>> separate channel? Or just use REG_FADC as the raw value and forget
>> about REG_ADC? In any case we would want another attribute to control
>> the filter window size.
> ...
> 
> Hello David,
> 
> Thank you for the review and suggestions.
> Sorry for not adding any comments about that in v12. From what I understood from our previous conversation, for now the code could have one channel to keep things simple, since we’re not sure if anyone will actually need to read both the filtered and unfiltered data at the same time.
> 
> I was thinking of sending a separate set of commits to address that after this one gets merged, as it will involve new code changes related to adding a function to configure how many ADC readings are included in the mean calculation, and adding a new attribute to sysfs.
> 
> Since both IIO_CHAN_INFO_RAW and IIO_CHAN_INFO_AVERAGE_RAW are currently returning the same value, I could drop IIO_CHAN_INFO_AVERAGE_RAW in v13 and add it back in the next series of commits to implement the related feature.
> 
> I would like to know your thoughts about it, because if you prefer, I could change my plans and implement it in v13.
> 
> Best Regards,
> Marilene
> 

Since everything else looks good, I think Marcelo's suggestion to drop
averaging from this series and add it in a later series is the best advice.