From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5D6638F94C for ; Mon, 13 Jul 2026 07:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783928207; cv=none; b=NFnwwjW+dYuA3KKOvh8Itq8c1DY0CaDpuvpwyCY2H0lSbOYCcecZcyHqRi5657s2AIKNy3BbzWYnAOznbTsJgJ3uxIRIB4q2uhHBk6hzolxGL3BPHzDvEfPHMVMFf4Y+SFn9AIOFxe0mKW7ItyD7jFzw/iI8D5zuFaPclSKwwpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783928207; c=relaxed/simple; bh=yJOmHcsl5ArviAtVN3rNnu5M3BpjhjOOBRK1bamLmdE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I/JYt14kUh1cUKf2xy12GAqqpsAqzowwwPCuJrY2uRptyi7AkA1q89sSKb9AtwBXx1JNXy/CiROmobJBHYmt2vQFtCwSikZTzJnrkqSJ58mnoyMbhwfgGCOi+kNyQVLqNa+txAaOwTfCn827+Zsr0CwG2RI6/7CEtxt5TBK2Wco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=yQ4juvx0; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=aeUPCcqv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=XwrHEvOG; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Tvug+SP8; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="yQ4juvx0"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="aeUPCcqv"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XwrHEvOG"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Tvug+SP8" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EF73277430; Mon, 13 Jul 2026 07:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783928204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fcwDktWx0MX7A6m2tZsP59pH2CHhK2YQavo+uWy1VsQ=; b=yQ4juvx0QgrFDgtA4wkMKTnv4JjZBUDFA5hyG48yg3XnoSGaqYMCnBFzO7k+Sfp0ydLMkK TPziRAGqu/f/aN/diFTGq8yPQBjrGzj4ZEik7g6myhOgFihnAP7cUpdoH5s8ESMj57rLYz WKl+UvTVdRO7utZeOHP+PUxGgjf9Sck= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783928204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fcwDktWx0MX7A6m2tZsP59pH2CHhK2YQavo+uWy1VsQ=; b=aeUPCcqvtZFE5Wzz+OVj58RES/B18adSAwUq5aArCD1/zJY7vCWs0vXBM5f5X2JOz0tgvi 48juXXUHrVtTAICQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XwrHEvOG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Tvug+SP8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783928203; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fcwDktWx0MX7A6m2tZsP59pH2CHhK2YQavo+uWy1VsQ=; b=XwrHEvOGXUjdbp9DVSEiRdnlA5blFTjKca2cE3U3naydKNkAWq6etlQtg8zGYZ0zmYEY5O ZcOQmeIGKfbB6XSrIxrThdC+uqg/rv+xBQaac1jAKd09A2jAuO20xX3KueEP3mpZsF3Ucn UHHw7O0X1I0LNdaMmcMQBxOVT3PMNxc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783928203; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fcwDktWx0MX7A6m2tZsP59pH2CHhK2YQavo+uWy1VsQ=; b=Tvug+SP88mB9TPw0RdsC5R4BTjkOY/H4V+XDGjI6lsZI/8vAkOYfY4EB4tMRl4nUiO30KG oTUi8f00YHgYsbDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 97C0A779AE; Mon, 13 Jul 2026 07:36:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9wfZI4uVVGqncAAAD6G6ig (envelope-from ); Mon, 13 Jul 2026 07:36:43 +0000 Message-ID: Date: Mon, 13 Jul 2026 09:36:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 16/16] nvme: Add support for CQT to nvme host To: Mohamed Khalfella , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Randy Jennings , Dhaval Giani Cc: Aaron Dailey , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260712022437.3743117-1-mkhalfella@purestorage.com> <20260712022437.3743117-17-mkhalfella@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260712022437.3743117-17-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[purestorage.com,broadcom.com,gmail.com,nvidia.com,lst.de,kernel.dk,kernel.org,grimberg.me]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[purestorage.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: EF73277430 X-Spam-Score: -4.51 On 7/12/26 4:23 AM, Mohamed Khalfella wrote: > TP4129 KATO Corrections and Clarifications defined CQT (Command Quiesce > Time) which is used along with KATO (Keep Alive Timeout) to set an upper > limit for attempting Cross-Controller Recovery. Add ctrl->cqt, read its > value from controller identify response, expose it via sysfs, and have > nvme_fence_timeout_ms() account for it. > > Use CQT to drive time-based recovery in fc, rdma, and tcp transports. > Add a fenced_work delayed work to each transport controller. If CCR > fails, fencing_work switches to error recovery immediately if CQT is not > supported. Otherwise it schedules fenced_work after the remaining fence > timeout, which also switches to error recovery when scheduled. > > Signed-off-by: Mohamed Khalfella > --- > drivers/nvme/host/core.c | 1 + > drivers/nvme/host/fc.c | 41 +++++++++++++++++++++++++++++++++++---- > drivers/nvme/host/nvme.h | 5 +++-- > drivers/nvme/host/rdma.c | 41 +++++++++++++++++++++++++++++++++++---- > drivers/nvme/host/sysfs.c | 2 ++ > drivers/nvme/host/tcp.c | 41 +++++++++++++++++++++++++++++++++++---- > 6 files changed, 117 insertions(+), 14 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich