public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: baichen <ttdxba@gmail.com>
Cc: linux-kernel@vger.kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH] workqueue: check for NULL wq in queue_delayed_work_on()
Date: Tue, 17 Mar 2026 07:54:14 -1000	[thread overview]
Message-ID: <da323a4694dfbdc5f262059091942082@kernel.org> (raw)
In-Reply-To: <20260316180300.66423-1-ttdxba@gmail.com>

Hello,

Calling workqueue APIs with a NULL wq is always a caller bug and adding
NULL checks to all APIs isn't the right approach. The WARN was there as a
debug aid but it doesn't actually prevent the crash, so it's misleading.
I'm removing it instead.

Thanks.

--
tejun

  reply	other threads:[~2026-03-17 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 18:03 [PATCH] workqueue: check for NULL wq in queue_delayed_work_on() baichen
2026-03-17 17:54 ` Tejun Heo [this message]
2026-03-17 17:56 ` [PATCH wq/for-7.1] workqueue: Remove NULL wq WARN in __queue_delayed_work() Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da323a4694dfbdc5f262059091942082@kernel.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ttdxba@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox