From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E8D233D9E for ; Fri, 10 Jul 2026 18:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783707106; cv=none; b=NF85Lywo1HdpsVC86g7WlpMN5JY1E5nnji0nyxqGQrQG68nA3oHZyoOCY98LsJ2y5OvwbaF9KqcU/pGwlyDDThy9RmWadA7cd3NufZEBu/2x39XvyCw6bnsZgaYzwEieOWGX58aPVeDlGaKYr42WNGMeLlO6YLGBAQqLk7wILCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783707106; c=relaxed/simple; bh=SRW1hyRy2MLVxxlmoOhn02LtikzideCrttxVVyIVT/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lAOWfExZguN0tjaBMjUT4bD6sheHnxb9m0QGp2/w0EnQF2n8DAiBnGRU+4pAyk6nKXoGHigQWnDdwlIhrYacR1nZmjfHW3S1URfmpTusZdfi7K2AWLQ7Mb7Xe7MJDmpsPEGzArPEl5+sj5Llq0o2tzHNMBWlCZxqpbgWzPPUO00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fOc1Bbfz; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fOc1Bbfz" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-69532288224so2237470a12.0 for ; Fri, 10 Jul 2026 11:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783707103; x=1784311903; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T+3p5jzJlBIxDNBN4ODBt7dUlm5yf6OTA6BJPqQx+TM=; b=fOc1BbfzcXFZ3xcyomRun0nZ7wDLl4nmOiwkQ6YZfyRfqEeDP8Ayx4oQouydXwOFan vPc70iPfrRU+3ve85y3mFUd0IlCAr6yHJa0R5InyfZaqkycT+GX1cGg+PzGcHrU0A9fv VJREi/MLAVVd1d3ABaqhVIGmSr7Bk2UiSPZpvk2BhakPmlJJx8bxjyYq97rADibiYt9p oJlyWqP7PXVoABlXy6OcO4oy9mJ74Je6oCyPMaguOdVLTN+ldDuV6TA2NYR7+AnG7URh DgEIWfwGu1aIOk/0eHR8FrmIgpilfG8Y0RGcnO9kl0QBGnvmwVq0Gv7N99jRTdJpvDzq wsVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783707103; x=1784311903; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T+3p5jzJlBIxDNBN4ODBt7dUlm5yf6OTA6BJPqQx+TM=; b=Dn71gKS5CoL50/VVnpDsESnq3x+JlVuuhew6RtP1tu/mGzMDuuw8m56v57ZH44VOCa HoE496KGc4Or+RNniNBDAIeSQ2O8fohmX4MyGcm5F/Voy8ExziUvOe5/12bV+PRZtWWe jy0fKwRfzTsvMMGGNCgDlx/+UWcnaFCFS+swtkuA34tG1Fhdy4cQB32V8yhcM/WFgE3P lTc+UrD7WCX+RVyQIJVZqRcJV3Opq0Z5DSNUULGsmAtpUeXzwUHdYKRjNsXA8Z/kf9VX toYFAaskPw08axSGBYp4yi/TX4Go9owXXYPl3Scdlz4eE9oEWVZugYiNyeIPyWC1jvFB f8/g== X-Forwarded-Encrypted: i=1; AHgh+Rr2OMGBHCUHUDZABf6nMFpmPLjdw/VnTTS7HXRLwMHDjbexv8avSCH3ZRo9MiHAuYLHXxmGwYh1aLGAlEM=@vger.kernel.org X-Gm-Message-State: AOJu0YzVlDL32bTPBHm7XgfoeJBmLyisewFVK+62icAGJSIYlryhCfa9 5xRIgaqWcTqbNxsCJInqj/Z7Loni2JNRS0SJ8frFL8lHZ4L4SHeGrIjm X-Gm-Gg: AfdE7cmhnr9KnBpRW5TsswLlDP4b3N57TlxB0JfgLIvjIiDVt1zDcHjBvf7KTEF+E+S 0Er0wibLUpZbkt8+9LBCKDQ0xzM+hPhiWqXoQ788yddVueQQnwCL2B3AFrF3c1ufGyPcwJFu9fP ZndAAT27R/b9hObMk3r13nMJM24BJDUXPpEfQDxiZk6VLeH6AKuHr6vHnRfREqYWhCfcDkx/V5E 66kKPCk9B4hu2mjLjkLSVsEUmBzlTcLmMsGy53BUUNZlgTFnv/fvjl3MNfU5clJ/PFMMet0VSeR pF9bu6idwsGJTGlSOo3R5qqGgP8LJ21eDBjAE1frYSMtlTO/IM82JGQ3r05tQNauYq3vVTVUX8Z SxXZ6RXaY9xvUwauKnOkRXXPiuSG2Zl68EU0RSDKRsfbAMBc2u5t+HrEZv93+Q2OHs7Sb8U3JE4 dkKpmcFL0b0lz5Lz/cxDgU+XxeVfPb2m8C4S5af9Ff8JnyUCA36dkqBZsHnpfDbzvnpQvxvb44z Nka92pcSjjF9SITuPUI99s30n7msTSVIdQi6dYNBDE5iy4MSGLB/xgZidqOfYs= X-Received: by 2002:a05:6402:40d0:b0:69a:bce:f1de with SMTP id 4fb4d7f45d1cf-69c5f22d500mr200285a12.26.1783707103268; Fri, 10 Jul 2026 11:11:43 -0700 (PDT) Received: from [192.168.0.2] (dslb-002-205-021-241.002.205.pools.vodafone-ip.de. [2.205.21.241]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19ce4b4fsm11209189a12.10.2026.07.10.11.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 11:11:41 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 20:11:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 2/2] net: dsa: mv88e6xxx: flush the ATU when the hash algorithm changes To: Luke Howard , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , Gregory CLEMENT , Andrew Lunn , Richard Cochran Cc: Cedric Jehasse , Kieran Tyrrell , Max Holtmann , Max Hunter , Christoph Mellauner , Simon Gapp , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260710-mv88e6x41-fixes-v2-0-e23654c65aa0@padl.com> <20260710-mv88e6x41-fixes-v2-2-e23654c65aa0@padl.com> Content-Language: en-US From: Jonas Gorski In-Reply-To: <20260710-mv88e6x41-fixes-v2-2-e23654c65aa0@padl.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 10/07/2026 01:29, Luke Howard wrote: > Changing the ATU hash algorithm invalidates existing entries: those > loaded under the previous algorithm end up in different bins and read > back corrupted. > > Flush the ATU whenever the hash algorithm is changed through devlink > and reload the default broadcast entries. Per-VLAN ATU entries and > any static addresses are not replayed, so the hash must be selected > before the FDB or MDB are configured. If changing the algorithm at runtime isn't handled fully and the hw AFAIU gets out of sync (i.e. static entries get lost from hw, but retained in the linux bridge), maybe it would make sense to reject changing it while e.g. a bridge exist? Feels like an easy foot-gun for hard to debug network issues. Best regards, Jonas