Re: [PATCH 2/3] soc/tegra: pmc: Allow optional irq parent callbacks

Thierry Reding
2020-10-05T11:28:02Z

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Mon, Oct 05, 2020 at 12:14:42PM +0100, Marc Zyngier wrote:
> Make the PMC driver resistent to variable depth interrupt hierarchy,
> which we are about to introduce. The irq_chip structure is now
> allocated statically, providing the indirection for the couple of
> callbacks that are SoC-specific.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> drivers/soc/tegra/pmc.c | 65 ++++++++++++++++++++++++++++++++++-------
> 1 file changed, 54 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index d332e5d9abac..9960f7c18431 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -439,7 +439,6 @@ struct tegra_pmc {
> struct pinctrl_dev *pctl_dev;
>
> struct irq_domain *domain;
> - struct irq_chip irq;

Did you have any particular reason for pulling this out of the struct
tegra_pmc and making it a global variable?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]