From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C58BF257827 for ; Fri, 28 Nov 2025 15:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764343742; cv=none; b=RZ6GaESllLIsi94jIjaMkOyvhNDWmgE9koMe3g9skqbHLqvVC73aOXN9lRC/4GoQXF67BfdTldjSKAW1Y+OCvmjZ28DowiqLTSHPZBEW+TXsntesW8fkWiDpC8pV/xVnwD62XmcqDDIfPQRSwUYyxZTEqT8uTnZiFUOlVUmvGKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764343742; c=relaxed/simple; bh=tzK1e/crrIyk6HS0tE6PqlgLpCq6usNtvqsajFi6sMU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uOsTjD2ZmBNN8u/YC0kzbTVCrzIG9WW6pdWN8isaWmfppdAPprNVaFQKxQDQZ0j/C3wEGlPPcS9k6K0SwdOy5/0LNbmZsw1eSYKePBoBAq/aWNUDWbL4t2Vfa8CZ505Vptwr5CzjgUuYGRQ9bWBMTv4q8ttBANMDeOReu/IPSA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com; spf=pass smtp.mailfrom=6wind.com; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b=IaL41xY5; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=6wind.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="IaL41xY5" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-42b4c7b2c8bso65334f8f.1 for ; Fri, 28 Nov 2025 07:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1764343739; x=1764948539; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=NAPgXXchXQHPvwVorfhvAIFztiTEQO3A7lNYNmsblO4=; b=IaL41xY5dqvYgiyuYTzxtLYalJUswWvtfnLU/66NO2Yo4cGiq4+gqIpIH8aSx8cbUH s4KlP48dzdVCVWOpu0ZYm22MhwiVTzr7XEMzhLFx/EJpW2Ck6YH5/+hiVJU8jgdupYv2 EaytZ337FnVgqtdyvoxKq3gzA9Lv/9VHUui5GUibyp0uvYGqBz92/qyDKaJCC8/rSC7g 4cODCv9oh32yFWi0joloSwQGHcgZ+jeg2rPQkdfU54kPOYxAEWEBdpgXp9M0B2rzM2LD AgnNoQb7nJcN8gzvCmypRAtd3354vnM9BBxY7NEgnf3SEoK0TrVo3LXY6SmUv7ALVnGR ZIZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764343739; x=1764948539; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NAPgXXchXQHPvwVorfhvAIFztiTEQO3A7lNYNmsblO4=; b=nPKbH7JeaK0bZZJ9Bf9dCLgHOFXrqS+8yXq4gjYYfYOdoXm8bE9FgYTpotb7Tjtrsw 77pOpE4DeG82aSVZl+qICmNATdJ5RPk7mDtwQHFw4e8yrGidFIKrYZJWfwrIxA6ocZu8 fw6Kcd0ypeYhkOaYRPqHMQg6jxNiPGPSlqjk1Xivn70kzLxUKLLJ+n0H4Vr7anKXPiio hqN/2m82jZ5ndx76GNxKSRZ4GJm2VTA3dO0629oICb0U+YnYc6/DEVV5eYwb9+1dT1yC uvVnCylU6MVllqXTKMUZc+BvjKFzPYOdDwAjkdgvXmkC4OZVbY4hoMujo6j6cq0Q+okI 3HCg== X-Forwarded-Encrypted: i=1; AJvYcCWcWDq4THzTuiM4+BJ9mb5OUwL9aE/tIbk6kP1fNce2u78XfTq42BwpDM7xXZ/UoL6NfMD8We2FL4lR82o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx936yOBvN1dbahPYJqHwDKVshnzTjb5wmeelD9SCeBAsNwojd1 RmoVXuHnjOPkmD4yXTPIUlxJION5rJHiw1WJQ9vGKbYmWQ5loADk49NiIf+NZXuo6PU= X-Gm-Gg: ASbGncuCB5lIpvNKAiHZRJewpIJa5WK/qMX+ZHmwpHX2TYKJqkMviCZGymBzYuDW1l0 XKUn9zuv9xeQaY1PXn+9G4Vyne2UxoZxP4m02knczHNJNrlvF0ML/34+WnlTm6EY8hMttPTaRXq LYzOfEiHddA9YGbVL9/akQed1YB9GBJ34yVSY95quXu3MUo2j5kRbrc6hF0Dj3BX7ccq+8cl2tz eA10bCRH/RwWcvFmVBI42Cijkn7QTEGm8x3hb77QF3Qh9H9O2QK99ozTkZM2YByg3gDgtyD2XHk /78MexVWwe+B6K47ahUVZIuoPsHV2NkTT2teIDthcGll7csV8oa5i0O2Y8wcYPnKMVN2sKxpskK 1RHigvwt/Fpy5IvzhiHOfmPcPc7fZiFw/2p8BIZk5DIU+Tk0YLboGJ5ZFIp4yMIhvA697/j/7Av ko9lmRQkrd6zHyG3OdUrvOM5qewwG2yFlAjEglDlKB9JZ87DgDEGbh4Sdgj3meSfk= X-Google-Smtp-Source: AGHT+IFT8j1VU3XxSr0n64qOgz88JdtoD+z+f0TMDct1OT4UqOclTIHzeKuHbUGO2UvCGjfzJ7rmwg== X-Received: by 2002:a05:6000:1863:b0:429:d725:40f0 with SMTP id ffacd0b85a97d-42cc1d13128mr15005877f8f.5.1764343739067; Fri, 28 Nov 2025 07:28:59 -0800 (PST) Received: from ?IPV6:2a01:e0a:b41:c160:6a1d:efff:fe52:1959? ([2a01:e0a:b41:c160:6a1d:efff:fe52:1959]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5d613esm10591284f8f.11.2025.11.28.07.28.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Nov 2025 07:28:58 -0800 (PST) Message-ID: Date: Fri, 28 Nov 2025 16:28:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH v2] net/ipv6: allow device-only routes via the multipath API To: azey Cc: Jakub Kicinski , David Ahern , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , netdev , linux-kernel References: <3k3facg5fiajqlpntjqf76cfc6vlijytmhblau2f2rdstiez2o@um2qmvus4a6b> <20251124190044.22959874@kernel.org> <19ac14b0748.af1e2f2513010.3648864297965639099@azey.net> <85a27a0d-de08-413d-af07-0eb3a3732602@6wind.com> <19ac5a2ee05.c5da832c80393.3479213523717146821@azey.net> <1d44e105-77bd-42e7-81f5-6e235fd12554@6wind.com> <19aca794ddd.105d1f97f173752.5540866508598154532@azey.net> From: Nicolas Dichtel Content-Language: en-US Organization: 6WIND In-Reply-To: <19aca794ddd.105d1f97f173752.5540866508598154532@azey.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Le 28/11/2025 à 13:38, azey a écrit : > On 2025-11-28 09:38:07 +0100 Nicolas Dichtel wrote: >> With IPv6, unlike IPv4, the ECMP next hops can be added one by one. Your commit >> doesn't allow this: >> >> $ ip -6 route add 2002::/64 via fd00:125::2 dev ntfp2 >> $ ip -6 route append 2002::/64 dev ntfp3 >> $ ip -6 route >> 2002::/64 via fd00:125::2 dev ntfp2 metric 1024 pref medium >> 2002::/64 dev ntfp3 metric 1024 pref medium >> ... >> $ ip -6 route append 2002::/64 via fd00:175::2 dev ntfp3 >> $ ip -6 route >> 2002::/64 metric 1024 pref medium >> nexthop via fd00:125::2 dev ntfp2 weight 1 >> nexthop via fd00:175::2 dev ntfp3 weight 1 >> >> Note that the previous route via ntfp3 has been removed. > > I just tested your example in a VM with my patch, and everything works > as you described. This is due to fib6_explicit_ecmp not overriding I tested your patch ;-) 'ip -6 route append 2002::/64 dev ntfp3' failed to add the next hop, a second route was created.