public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Shi <seakeel@gmail.com>
To: Matthew Wilcox <willy@infradead.org>, alexs@kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Andreas Larsson <andreas@gaisler.com>,
	"open list:SPARC + UltraSPARC (sparc/sparc64)"
	<sparclinux@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	kernel test robot <lkp@intel.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Qi Zheng <zhengqi.arch@bytedance.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Zi Yan <ziy@nvidia.com>, Kevin Brodsky <kevin.brodsky@arm.com>,
	Mike Rapoport <rppt@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] arch/sparc: fix unused variable warning
Date: Thu, 8 Jan 2026 09:26:28 +0800	[thread overview]
Message-ID: <da4e67bf-e671-46a6-8b09-19193c747c37@gmail.com> (raw)
In-Reply-To: <aV5xv0PfUvdc5QFE@casper.infradead.org>



On 2026/1/7 22:46, Matthew Wilcox wrote:
> On Wed, Jan 07, 2026 at 06:41:44PM +0800,alexs@kernel.org wrote:
>> From: Alex Shi<alexs@kernel.org>
>>
>>     arch/sparc/mm/init_64.c: In function 'arch_hugetlb_valid_size':
>>     arch/sparc/mm/init_64.c:361:24: warning: variable 'hv_pgsz_idx' set but not used [-Wunused-but-set-variable]
>>       361 |         unsigned short hv_pgsz_idx;
>>           |                        ^~~~~~~~~~~
> Looks like it's been unused since introduction in c7d9f77d33a7 ?
> 
> As such, why cc all these people who have absolutely nothing to do with
> it?  Use your brain, not a stupid script.

Thanks for the feedback, Matthew. You're right—the script was too 
aggressive for such a localized fix.

I used 'scripts/get_maintainer.pl' without enough manual filtering. 
Besides '--nogit-fallback', are there specific parameters or workflows 
you recommend to keep the CC list lean for trivial cleanups like this?

I'll be more surgical with the CC list on the next version.

Thanks!

  reply	other threads:[~2026-01-08  3:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 10:41 [PATCH v2] arch/sparc: fix unused variable warning alexs
2026-01-07 14:46 ` Matthew Wilcox
2026-01-08  1:26   ` Alex Shi [this message]
2026-01-08  2:30   ` Alex Shi
2026-01-26 16:43 ` Andreas Larsson
2026-01-26 16:58   ` Andreas Larsson
2026-02-02  6:56   ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da4e67bf-e671-46a6-8b09-19193c747c37@gmail.com \
    --to=seakeel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexs@kernel.org \
    --cc=andreas@gaisler.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=kevin.brodsky@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=rppt@kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=zhengqi.arch@bytedance.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox