From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B14DC433EF for ; Tue, 31 May 2022 18:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347191AbiEaS6V (ORCPT ); Tue, 31 May 2022 14:58:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345970AbiEaS6T (ORCPT ); Tue, 31 May 2022 14:58:19 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F465623B for ; Tue, 31 May 2022 11:58:17 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id h5so11809243wrb.0 for ; Tue, 31 May 2022 11:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3jqFKxuM0VdeJ/MyByEyz+wyq2IRR/BBVsyEiN0wEB8=; b=WEETQz6q/FWDtvpNTT4MeaxxeAJrhldu2uL5U/wiI5BGoF0Gn/2MkEqnlWTohkqfNL zUwt7LiMyWJxJS0M5FUEsSiecRclKm84gYN+DeZ+Ef/BbWtLVf+kpvoUai3Kp5phExa8 NEJuRtL0p1mu6H4M1zWhFFLRldtWTBvdeX33agqaG5394MPaPY91cQ3/UYn7U4b2Kjr9 2ulNax3VDLzItei+PR72dqILLCSQBS8Zn3XeMEwikeWWodb7dCLPPKcqytvor/+I8rj0 mpEeMSYVX43ZatslYop6VK2XHssgPqsdwuoRTRCtwAd55TAj4ZWVh6CKxHuJKPkFhs59 lmzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3jqFKxuM0VdeJ/MyByEyz+wyq2IRR/BBVsyEiN0wEB8=; b=45nk9rsnOZnBUuAbSAGkOQNxi18B49CsMrYwXViAOn5WUi4NjOFPCGqA6TMQMDrRzC VFcKyHniNI0mpf/lu/31+twjukc60ixB3fXVp0PcqmIFvAMANo+alNeU2WXi2oC6FoKR EzlimK9gflj9wLWjmqh9kT5loHy+3wzgl5I+NW/lt1vleH3RrdFjJr74kEUE+hKRN7VI RaWGnDoqVZqrTVWYNcPsuUzu05bGgAMoE/65bnbFhdeq7w2JiOZHW7SjS32zSfAeSZEF Mr0SuMuDVbjHVVpbKjmJ3ffu5wio/CDQsE67Y/yVGU4muay3S/NCN6nsuzgzJQR/t7Fk Qyeg== X-Gm-Message-State: AOAM532POqOH8uquqiCJ1EQabjFQM1kp7oW+LfTWS6kZCaxuTHH5YPfk om0dUtpSF6Xnv0BPLhTTuA7Cjg== X-Google-Smtp-Source: ABdhPJzaXozUmfTumRxUq5m+SNRdgDLpeB6YFm8blpCdw8skJx9KTpGM+HSWp+5rOpD7JsvU6/af/A== X-Received: by 2002:a05:6000:1542:b0:20f:f4fc:4cd3 with SMTP id 2-20020a056000154200b0020ff4fc4cd3mr29118402wry.299.1654023495617; Tue, 31 May 2022 11:58:15 -0700 (PDT) Received: from [10.188.163.71] (cust-east-parth2-46-193-73-98.wb.wifirst.net. [46.193.73.98]) by smtp.gmail.com with ESMTPSA id f8-20020a5d64c8000000b0020d07958bb3sm12599259wri.3.2022.05.31.11.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 11:58:15 -0700 (PDT) Message-ID: Date: Tue, 31 May 2022 12:58:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 0/5] io_uring: add opcodes for current working directory Content-Language: en-US To: Usama Arif , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: fam.zheng@bytedance.com References: <20220531184125.2665210-1-usama.arif@bytedance.com> From: Jens Axboe In-Reply-To: <20220531184125.2665210-1-usama.arif@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/22 12:41 PM, Usama Arif wrote: > This provides consistency between io_uring and the respective I/O syscall > and avoids having the user of liburing specify the cwd in sqe when working > with current working directory, for e.g. the user can directly call with > IORING_OP_RENAME instead of IORING_OP_RENAMEAT and providing AT_FDCWD in > sqe->fd and sqe->len, similar to syscall interface. > > This is done for rename, unlink, mkdir, symlink and link in this > patch-series. > > The tests for these opcodes in liburing are present at > https://github.com/uarif1/liburing/tree/cwd_opcodes. If the patches are > acceptable, I am happy to create a PR in above for the tests. Can't we just provide prep helpers for them in liburing? -- Jens Axboe