From: Sergey Shtylyov <sergei.shtylyov@gmail.com>
To: Duoming Zhou <duoming@zju.edu.cn>, linux-usb@vger.kernel.org
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
mitltlatltl@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: fix probe failure in gaokun_ucsi_probe()
Date: Tue, 25 Nov 2025 11:53:42 +0300 [thread overview]
Message-ID: <da4ed386-505f-459a-91f0-292b77cfb74f@gmail.com> (raw)
In-Reply-To: <20251125082505.52249-1-duoming@zju.edu.cn>
On 11/25/25 11:25 AM, Duoming Zhou wrote:
> The gaokun_ucsi_probe() uses ucsi_create() to allocate a UCSI instance.
> The ucsi_create() validates whether ops->poll_cci is defined, and if not,
> it directly returns -EINVAL. However, the gaokun_ucsi_ops structure dose
s/dose/does/.
> not define the poll_cci, causing ucsi_create() always fail with -EINVAL.
> This issue can be observed in the kernel log with the following error:
>
> ucsi_huawei_gaokun.ucsi huawei_gaokun_ec.ucsi.0: probe with driver
> ucsi_huawei_gaokun.ucsi failed with error -22
>
> Fix the issue by adding the missing poll_cci callback to gaokun_ucsi_ops.
>
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
[...]
MBR, Sergey
next prev parent reply other threads:[~2025-11-25 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 8:25 [PATCH] usb: typec: ucsi: fix probe failure in gaokun_ucsi_probe() Duoming Zhou
2025-11-25 8:32 ` Greg KH
2025-11-25 8:53 ` Sergey Shtylyov [this message]
2025-11-25 11:08 ` Pengyu Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da4ed386-505f-459a-91f0-292b77cfb74f@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=duoming@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mitltlatltl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox