From: Vlastimil Babka <vbabka@suse.cz>
To: Shivank Garg <shivankg@amd.com>,
david@redhat.com, akpm@linux-foundation.org, brauner@kernel.org,
paul@paul-moore.com, rppt@kernel.org, viro@zeniv.linux.org.uk
Cc: seanjc@google.com, willy@infradead.org, pbonzini@redhat.com,
tabba@google.com, afranji@google.com, ackerleytng@google.com,
jack@suse.cz, hch@infradead.org, cgzones@googlemail.com,
ira.weiny@intel.com, roypat@amazon.co.uk,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass
Date: Thu, 19 Jun 2025 11:13:49 +0200 [thread overview]
Message-ID: <da5316a7-eee3-4c96-83dd-78ae9f3e0117@suse.cz> (raw)
In-Reply-To: <20250619073136.506022-2-shivankg@amd.com>
On 6/19/25 09:31, Shivank Garg wrote:
> Export anon_inode_make_secure_inode() to allow KVM guest_memfd to create
> anonymous inodes with proper security context. This replaces the current
> pattern of calling alloc_anon_inode() followed by
> inode_init_security_anon() for creating security context manually.
>
> This change also fixes a security regression in secretmem where the
> S_PRIVATE flag was not cleared after alloc_anon_inode(), causing
> LSM/SELinux checks to be bypassed for secretmem file descriptors.
>
> As guest_memfd currently resides in the KVM module, we need to export this
Could we use the new EXPORT_SYMBOL_GPL_FOR_MODULES() thingy to make this
explicit for KVM?
next prev parent reply other threads:[~2025-06-19 9:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 7:31 [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Shivank Garg
2025-06-19 8:45 ` Christian Brauner
2025-06-19 9:13 ` Vlastimil Babka [this message]
2025-06-19 9:53 ` Shivank Garg
2025-06-19 10:38 ` Christian Brauner
2025-06-19 11:01 ` Mike Rapoport
2025-06-19 12:06 ` Christian Brauner
2025-06-19 12:19 ` Mike Rapoport
2025-06-20 15:02 ` Sean Christopherson
2025-06-23 5:32 ` Shivank Garg
2025-06-23 10:16 ` Christian Brauner
2025-06-23 14:00 ` Christoph Hellwig
2025-06-23 14:01 ` Christoph Hellwig
2025-06-23 14:21 ` Vlastimil Babka
2025-06-23 14:22 ` Christoph Hellwig
2025-06-23 14:28 ` Peter Zijlstra
2025-06-24 9:02 ` Christian Brauner
2025-06-25 9:05 ` Christian Brauner
2025-06-25 9:18 ` Vlastimil Babka
2025-06-25 8:02 ` Vlastimil Babka
2025-06-25 8:09 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da5316a7-eee3-4c96-83dd-78ae9f3e0117@suse.cz \
--to=vbabka@suse.cz \
--cc=ackerleytng@google.com \
--cc=afranji@google.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cgzones@googlemail.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=pbonzini@redhat.com \
--cc=roypat@amazon.co.uk \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shivankg@amd.com \
--cc=tabba@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).