From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE03C433FE for ; Mon, 25 Apr 2022 19:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245029AbiDYTtA (ORCPT ); Mon, 25 Apr 2022 15:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245022AbiDYTsy (ORCPT ); Mon, 25 Apr 2022 15:48:54 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A93BE1EEEC for ; Mon, 25 Apr 2022 12:45:49 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id z2so18323646oic.6 for ; Mon, 25 Apr 2022 12:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZX5Ys886fW/dmB+y6iFegf8FHLGn6ZOTOb6+Agc8SSc=; b=W6JtEO0fy4FEMHz7GdcCLTFoa3nMGdRUexkGRjdE4DmKHqVMbwdEAXaRezpnGHYW4Y 71vyN9AX8EumgZpr7rUGaS1eqcWf4/IpOSaszRZMKJb6ISY4FwHJje4ENHBPoWHefpLS TFk3aIxgTGsKEuCiKunc+Qlmmon2BGs648krw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZX5Ys886fW/dmB+y6iFegf8FHLGn6ZOTOb6+Agc8SSc=; b=Oqk0FuAgWoq6iA/dnxkwkkT/Z13V2bp8TdQ0oc45/a0nVxT8PnDeXYFq0U0VH3mL2x cfoNTgeLvHUPPsFf+wzbrAonzGeez85Sner0UXXrop+KhVKiWUgyreteDjmAMItu86Db 2MRPcdoWGyExafuiAcphG7YCylDaGpKmdxXXqnQaBXkjuyFdDK2Jtsa16laB30J+LNAK XkL0FPK4RnY/fGakBBrZS4wOkurAkc9cfh4mntd/wWvydoIvPYf7VPvNsdemVFprYXfH DPivBU+XKwQXoBy6SiMrrVjuosGuVJ1QygqGndk00f/z0XiAUeEn1nadTCBNLPG9Ve07 Ni/g== X-Gm-Message-State: AOAM5313v27K5hJFTZBZu9YRWk6cW5RgRutRN5ImmtKoPiPM0Y7BSr0R lItqwa6KVaNQtNfHL87prwlIHg== X-Google-Smtp-Source: ABdhPJxTQzTraVnJy0Bh8b4T5Ky3qs+HiBT9vzOXWWhdmnV1EHCnCrF8OpXJbepsLkiyfOAAH+XhXw== X-Received: by 2002:a05:6808:1b06:b0:325:2c06:dadf with SMTP id bx6-20020a0568081b0600b003252c06dadfmr3244673oib.159.1650915949018; Mon, 25 Apr 2022 12:45:49 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id c19-20020a05687093d300b000e686d1386csm40543oal.6.2022.04.25.12.45.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 12:45:48 -0700 (PDT) Subject: Re: [PATCH 3/5] selftests: firmware: Fix the request_firmware_into_buf() test for XZ format To: Takashi Iwai , Luis Chamberlain Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Nick Terrell , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220421152908.4718-1-tiwai@suse.de> <20220421152908.4718-4-tiwai@suse.de> From: Shuah Khan Message-ID: Date: Mon, 25 Apr 2022 13:45:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220421152908.4718-4-tiwai@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/22 9:29 AM, Takashi Iwai wrote: > The test uses a different firmware name, and we forgot to adapt for > the XZ compressed file tests. > > Fixes: 1798045900b7 ("selftests: firmware: Add request_firmware_into_buf tests") > https://lore.kernel.org/all/20210127154939.13288-1-tiwai@suse.de/ > Signed-off-by: Takashi Iwai > --- > tools/testing/selftests/firmware/fw_filesystem.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh > index 731f011def78..3ac09b401a83 100755 > --- a/tools/testing/selftests/firmware/fw_filesystem.sh > +++ b/tools/testing/selftests/firmware/fw_filesystem.sh > @@ -504,6 +504,7 @@ test "$HAS_FW_LOADER_COMPRESS" != "yes" && exit 0 > > # test with both files present > $RUN_XZ -k $FW > +$RUN_XZ -k $FW_INTO_BUF > config_set_name $NAME > echo > echo "Testing with both plain and xz files present..." > @@ -529,6 +530,7 @@ done > > # test with only xz file present > mv "$FW" "${FW}-orig" > +mv "$FW_INTO_BUF" "${FW_INTO_BUF}-orig" > echo > echo "Testing with only xz file present..." > for i in $(seq 1 5); do > Thank you. Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah