From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbcJAPPH (ORCPT ); Sat, 1 Oct 2016 11:15:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39329 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbcJAPPE (ORCPT ); Sat, 1 Oct 2016 11:15:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 1D6546180A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF To: Vinod Koul References: <1475115167-5898-1-git-send-email-okaya@codeaurora.org> <1475115167-5898-5-git-send-email-okaya@codeaurora.org> <20161001061710.GF2467@localhost> Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Wei Yongjun , Andy Shevchenko , linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: Date: Sat, 1 Oct 2016 11:15:00 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161001061710.GF2467@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/1/2016 2:17 AM, Vinod Koul wrote: > On Wed, Sep 28, 2016 at 10:12:41PM -0400, Sinan Kaya wrote: >> Configure the DMA bindings for the device tree based firmware. >> >> Signed-off-by: Sinan Kaya >> --- >> drivers/dma/qcom/hidma_mgmt.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c >> index 82f36e4..e8f6b84 100644 >> --- a/drivers/dma/qcom/hidma_mgmt.c >> +++ b/drivers/dma/qcom/hidma_mgmt.c >> @@ -375,8 +375,11 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) >> ret = PTR_ERR(new_pdev); >> goto out; >> } >> + of_node_get(child); >> + new_pdev->dev.of_node = child; >> of_dma_configure(&new_pdev->dev, child); >> - >> + of_msi_configure(&new_pdev->dev, child); >> + of_node_put(child); > > should this be done unconditionally? Dont we needto call this only for > platforms with msi? I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any side effects on my testing either. > >> kfree(res); >> res = NULL; >> } >> -- >> 1.9.1 >> > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.