From: Markus Elfring <Markus.Elfring@web.de>
To: linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"Angelo Gioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Heiko Stübner" <heiko@sntech.de>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] pmdomain: mediatek: Use devm_platform_get_and_ioremap_resource() in init_scp()
Date: Mon, 5 Feb 2024 15:23:18 +0100 [thread overview]
Message-ID: <da6af483-5ee9-45cd-922e-d9d5364674dc@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 5 Feb 2024 15:08:27 +0100
A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pmdomain/mediatek/mtk-scpsys.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pmdomain/mediatek/mtk-scpsys.c b/drivers/pmdomain/mediatek/mtk-scpsys.c
index b374d01fdac7..9e7f0771e7e4 100644
--- a/drivers/pmdomain/mediatek/mtk-scpsys.c
+++ b/drivers/pmdomain/mediatek/mtk-scpsys.c
@@ -441,8 +441,7 @@ static struct scp *init_scp(struct platform_device *pdev,
scp->dev = &pdev->dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- scp->base = devm_ioremap_resource(&pdev->dev, res);
+ scp->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(scp->base))
return ERR_CAST(scp->base);
--
2.43.0
next reply other threads:[~2024-02-05 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 14:23 Markus Elfring [this message]
2024-02-05 16:31 ` [PATCH] pmdomain: mediatek: Use devm_platform_get_and_ioremap_resource() in init_scp() Geert Uytterhoeven
2024-02-05 17:28 ` Markus Elfring
2024-02-05 19:01 ` Geert Uytterhoeven
2024-02-06 6:48 ` Markus Elfring
2024-02-06 9:21 ` [PATCH v2] pmdomain: mediatek: Use devm_platform_ioremap_resource() " Markus Elfring
2024-02-06 9:26 ` Geert Uytterhoeven
2024-02-06 10:10 ` AngeloGioacchino Del Regno
2024-02-06 14:55 ` Ulf Hansson
2024-02-06 9:24 ` [PATCH] pmdomain: mediatek: Use devm_platform_get_and_ioremap_resource() " AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da6af483-5ee9-45cd-922e-d9d5364674dc@web.de \
--to=markus.elfring@web.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox