From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
linux-sound@vger.kernel.org, kai.vehmanen@linux.intel.com,
ranjani.sridharan@linux.intel.com,
yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
guennadi.liakhovetski@linux.intel.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] PCI: pci_ids: add INTEL_HDA_WCL
Date: Mon, 19 May 2025 09:18:40 +0300 [thread overview]
Message-ID: <da6da5ec-53a4-4e47-aac0-3ddcb3a1e8b9@linux.intel.com> (raw)
In-Reply-To: <20250515170318.GA1507459@rocinante>
On 15/05/2025 20:03, Krzysztof Wilczyński wrote:
> Hello,
>
> Just a few small nitpicks.
>
> Consider an update to the subject to match the history, e.g.,
>
> PCI: Add Intel Wildcat Lake audio Device ID
I have looked up the history and used the previous audio IP ID addition
commit as template:
a1f7b7ff0e10 ("PCI: pci_ids: add INTEL_HDA_PTL_H")
PCI: pci_ids: add INTEL_HDA_PTL_H
Add Intel PTL-H audio Device ID.
I will update and stick with the suggested suggestion for the future.
>> Add PCI id for Wildcat Lake audio.
>
> Also, for consistency with other such commits:
>
> Add Wildcat Lake (WCL) audio Device ID.
>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
>> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
>
> Acked-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
>
> Thank you!
>
> Krzysztof
--
Péter
next prev parent reply other threads:[~2025-05-19 6:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 18:02 [PATCH 0/5] ASoC/SOF/PCI/Intel: add Wildcat Lake support Peter Ujfalusi
2025-05-08 18:02 ` [PATCH 1/5] PCI: pci_ids: add INTEL_HDA_WCL Peter Ujfalusi
2025-05-15 17:03 ` Krzysztof Wilczyński
2025-05-19 6:18 ` Péter Ujfalusi [this message]
2025-05-08 18:02 ` [PATCH 2/5] ALSA: hda: add HDMI codec ID for Intel WCL Peter Ujfalusi
2025-05-08 18:02 ` [PATCH 3/5] ASoC: SOF: Intel: add initial support for WCL Peter Ujfalusi
2025-05-09 1:32 ` Mark Brown
2025-05-08 18:02 ` [PATCH 4/5] ALSA: hda: intel-dsp-config: Add WCL support Peter Ujfalusi
2025-05-08 18:02 ` [PATCH 5/5] ALSA: hda: hda-intel: add Wildcat Lake support Peter Ujfalusi
2025-05-12 12:59 ` [PATCH 0/5] ASoC/SOF/PCI/Intel: " Pierre-Louis Bossart
2025-05-13 6:23 ` Péter Ujfalusi
2025-05-14 12:47 ` Pierre-Louis Bossart
2025-05-14 13:09 ` Péter Ujfalusi
[not found] ` <c95dec28-b77d-47ff-95a3-d103991180ed@linux.intel.com>
2025-05-13 10:18 ` Péter Ujfalusi
2025-05-15 9:00 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da6da5ec-53a4-4e47-aac0-3ddcb3a1e8b9@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kw@linux.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).