Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

Ilpo Järvinen
2024-08-09T07:23:38Z

On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote:

> This test doesn't have support for other architectures. Altough resctrl
> is supported on x86 and ARM, but arch_supports_noncont_cat() shows that
> only x86 for AMD and Intel are supported by the test.

One does not follow from the other. arch_supports_noncont_cat() is only
small part of the tests so saying "This test" based on a small subset of
all tests is bogus. Also, I don't see any reason why ARCH_ARM could not be
added and arch_supports_noncont_cat() adapted accordingly.

> We get build
> errors when built for ARM and ARM64.

As this seems the real reason, please quote any errors when you use them
as justification so it can be reviewed if the reasoning is sound or not.

--
i.

> Hence add support in the Makefile to build this suite only for x86 and
> x86_64 architectures.
>
> Fixes: b733143cc455 ("selftests/resctrl: Make resctrl_tests run using kselftest framework")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/resctrl/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
> index f408bd6bfc3d4..d5cf96315ef9b 100644
> --- a/tools/testing/selftests/resctrl/Makefile
> +++ b/tools/testing/selftests/resctrl/Makefile
> @@ -3,7 +3,9 @@
> CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2
> CFLAGS += $(KHDR_INCLUDES)
>
> +ifeq ($(ARCH),$(filter $(ARCH),x86 x86_64))
> TEST_GEN_PROGS := resctrl_tests
> +endif
>
> LOCAL_HDRS += $(wildcard *.h)
>
>