From: Vlastimil Babka <vbabka@suse.cz>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
Zhenhua Huang <quic_zhenhuah@quicinc.com>
Cc: cl@linux.com, rientjes@google.com, roman.gushchin@linux.dev,
harry.yoo@oracle.com, surenb@google.com,
pasha.tatashin@soleen.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
quic_tingweiz@quicinc.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] mm, slab: clean up slab->obj_exts always
Date: Thu, 24 Apr 2025 18:48:46 +0200 [thread overview]
Message-ID: <da89dcd6-9369-4a87-9794-a0bf5772509b@suse.cz> (raw)
In-Reply-To: <aApoFXmDE-k2KFFV@black.fi.intel.com>
On 4/24/25 18:34, Andy Shevchenko wrote:
> On Mon, Apr 21, 2025 at 03:52:32PM +0800, Zhenhua Huang wrote:
>> When memory allocation profiling is disabled at runtime or due to an
>> error, shutdown_mem_profiling() is called: slab->obj_exts which
>> previously allocated remains.
>> It won't be cleared by unaccount_slab() because of
>> mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts
>> should always be cleaned up in unaccount_slab() to avoid following error:
>>
>> [...]BUG: Bad page state in process...
>> ..
>> [...]page dumped because: page still charged to cgroup
>
> Please, always compile test with `make W=1`. Since CONFIG_WERROR=y this
> effectively breaks the build with Clang.
I don't see why, nor observe any W=1 warnings, can you be more specific? Thanks.
next prev parent reply other threads:[~2025-04-24 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 7:52 [PATCH v2] mm, slab: clean up slab->obj_exts always Zhenhua Huang
2025-04-21 16:02 ` Suren Baghdasaryan
2025-04-22 7:10 ` Vlastimil Babka
2025-04-22 7:22 ` Zhenhua Huang
2025-04-24 16:34 ` Andy Shevchenko
2025-04-24 16:48 ` Andy Shevchenko
2025-04-24 16:48 ` Vlastimil Babka [this message]
2025-04-24 17:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da89dcd6-9369-4a87-9794-a0bf5772509b@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=cl@linux.com \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_zhenhuah@quicinc.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox