From: Gary R Hook <gary.hook@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: iommu@lists.linux-foundation.org, joro@8bytes.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] iommu/amd - Add debugfs support
Date: Mon, 29 Jan 2018 13:05:15 -0600 [thread overview]
Message-ID: <da9402d0-026a-225e-e160-4e41bcd80e6a@amd.com> (raw)
In-Reply-To: <20180127000045.gatkndpu64no3o3j@pd.tnic>
On 01/26/2018 06:00 PM, Borislav Petkov wrote:
> On Fri, Jan 26, 2018 at 05:52:15PM -0600, Gary R Hook wrote:
>> --- a/drivers/iommu/Kconfig
>> +++ b/drivers/iommu/Kconfig
>> @@ -135,6 +135,15 @@ config AMD_IOMMU_V2
>> hardware. Select this option if you want to use devices that support
>> the PCI PRI and PASID interface.
>>
>> +config AMD_IOMMU_DEBUG
>> + bool "Expose AMD IOMMU internals in DebugFS"
>> + depends on AMD_IOMMU && DEBUG_FS
>> + default n
>> + help
>> + With this option you can enable access to AMD IOMMU registers and
>> + data structures through debugfs. Select this to see information
>> + about the internal state of the device.
>> +
>> # Intel IOMMU support
>> config DMAR_TABLE
>> bool
>> diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
>> index 1fb695854809..d9e9ed5f6cfc 100644
>> --- a/drivers/iommu/Makefile
>> +++ b/drivers/iommu/Makefile
>> @@ -9,7 +9,7 @@ obj-$(CONFIG_IOMMU_IO_PGTABLE_LPAE) += io-pgtable-arm.o
>> obj-$(CONFIG_IOMMU_IOVA) += iova.o
>> obj-$(CONFIG_OF_IOMMU) += of_iommu.o
>> obj-$(CONFIG_MSM_IOMMU) += msm_iommu.o
>> -obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o amd_iommu_init.o
>> +obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o amd_iommu_init.o amd_iommu_debugfs.o
>
> That looks like it needs to be:
>
> obj-$(CONFIG_AMD_IOMMU_DEBUG) += amd_iommu_debugfs.o
Of course. Thanks, Boris. I'll get that in v2.
next prev parent reply other threads:[~2018-01-29 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 23:52 [PATCH 0/5] Add debugfs info for the AMD IOMMU Gary R Hook
2018-01-26 23:52 ` [PATCH 1/5] iommu/amd - Add debugfs support Gary R Hook
2018-01-27 0:00 ` Borislav Petkov
2018-01-29 19:05 ` Gary R Hook [this message]
2018-01-26 23:52 ` [PATCH 2/5] iommu/amd - Add a 'verbose' switch for IOMMU debugfs Gary R Hook
2018-01-26 23:52 ` [PATCH 3/5] iommu/amd - Add a README variable for the " Gary R Hook
2018-01-26 23:52 ` [PATCH 4/5] iommu/amd - Expose the active IOMMU device table entries Gary R Hook
2018-01-26 23:52 ` [PATCH 5/5] iommu/amd - Add a debugfs entry to specify a IOMMU device table entry Gary R Hook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da9402d0-026a-225e-e160-4e41bcd80e6a@amd.com \
--to=gary.hook@amd.com \
--cc=bp@alien8.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox