Re: [PATCH 0/2] Fix V1P8_SIGNAL_ENA and HIGH_SPEED_ENA

Judith Mendez
2025-04-14T14:31:14Z

Hi Hiago,

On 4/12/25 8:20 AM, Hiago De Franco wrote:
> Hi Judith,
>
> On Fri, Apr 11, 2025 at 04:55:39PM -0500, Judith Mendez wrote:
>> Actually this was one of the previous implementations, I should have that
>> original patch somewhere. My understanding was that we do not like adding
>> new DT properties if we can find a way to apply the quirk in the driver.
>
> Got it, makes sense. This will work fine with eMMC, but for the SD card
> I am not seeing other option. Maybe we could use both implementations?
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 4e1156a2f1b8..db8ee66e76d8 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -888,7 +888,7 @@ static int sdhci_am654_get_of_property(struct platform_device *pdev,
>
> /* Suppress V1P8_SIGNAL_ENA for eMMC */
> device_property_read_u32(dev, "bus-width", &bus_width);
> - if (bus_width == BUS_WIDTH_8)
> + if (bus_width == BUS_WIDTH_8 || device_property_read_bool(dev, "ti,suppress-v1p8-ena"))
> sdhci_am654->quirks |= SDHCI_AM654_QUIRK_SUPPRESS_V1P8_ENA;
>
> So the driver applies the quirk for eMMC and we set the DT property for
> SD card. Not sure which one is the best, but maybe it is another option.
> Let's see what Adrian also thinks about that.

I like it, sure lets see what Adrian says, thanks for your suggestion.

~ Judith