From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E619C392C3B for ; Tue, 17 Mar 2026 08:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773734866; cv=none; b=RmTpBrbQTXNiQAx6SCZspCgJowwp/bMyrCq1wciP8aZl71xKNZRnO0VliS4j1/wWvDJMhCvErJlf+u7N+vyZeP9n6YHm1IAgVAVB4kBfIHzpv54BseeTxFZSxzqhPU9E+Y/1VOvpFikOlgRgZH7Nh1vJENeglMua1sqep2XPDGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773734866; c=relaxed/simple; bh=xjMI3kWLb004RFGciwvvZcxiwmFj4VVzpHoNLJgITKQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V599DjbnhgwqEF7OKUx4g23j7zHt2QF+RlbqkTbC0HrJUuUdYwWr8KPXhqMCN3Ud9iCESU4CcPHvo87DSgW4CcCdSHLskUfTiIthEK2/eUj2Q7iiCqgsp5sPky+z6wHmhvo7c5pylBZHpMZOsoJOxtVymH9Nxdy5hIJ/tgbnZZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yr/HjY3i; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yr/HjY3i" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b8f97c626aaso850733366b.2 for ; Tue, 17 Mar 2026 01:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773734863; x=1774339663; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zH58nQVPnaeEnUw730ASGfF9l+ejJ6sv9p1FAkERXbs=; b=Yr/HjY3i0z05NXV2n+9u2rLpjSTAQA6C5n5F6bXf5kuhRPunLI+fR5ENlF8X2e/2qY aiE547oHcpobbrStQkqGCvT2OdzmG5jogJYsVCyd356eEWLhVy9wvxlPMOKyeLpJy1JC FKWklfEzrseRM97NkJ8573zCuA4bUaZnokqkXtwOQ+9X6uj3jMM7o5elCcEcSS8pAV2h k/hiqVNqkXSidFLyq4ZgLQYEOfTnnbr2gL2KDmFAFIjh+7zEcrFcJeGQqsW0nqwDZxya H0CGYEBuohgoLOZKwRiJXTRvPewVLChYCHwc/7n/lKI5w+Xq0W+ajSb+K0A/lD/Ntr08 TZIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773734863; x=1774339663; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zH58nQVPnaeEnUw730ASGfF9l+ejJ6sv9p1FAkERXbs=; b=Vykdq/Y86elLr5zgJMH/vXaWjR4TBDZCQSUxZlwq16Ja7V5+uZqvBZ/T2Rud/g0wpB tE87hOz841DsETMnqFgxLSjeAiN8gzWG8mKGgwL3qD3sA5UpSTDC4cdVvv80ZMYQCBgw BGfuR4DTaMMx94OFKytU+7ArkCkafOB4wq+4oq+sM+7IWyk3lA/LptsmqDoUBvW05Hn/ KEHAjN4MxOEL9pk77kbQoALTaQWAtBBiu6i9sdd/goaHkE68A6ApTF2aAV4bVa0hyClH XpaN0O0L7zJ0KqisRFO2Nac+JPrXMSzqISYS2YlBau8W+h2TPqFpisBIFhWy8cKWtwg4 HmvQ== X-Forwarded-Encrypted: i=1; AJvYcCV6T+osgtl+yvltTTTrauCX2RRO/1J9X9rqXweigM/IhPxDTI9qjfsSv83yqiOCm27Z3SfBDSIYLsTKG5s=@vger.kernel.org X-Gm-Message-State: AOJu0YyDE29d9ptvOOFGXE3wwzubPi/0xr2G/zT9nrZFCz4JG48YYXlM 0CzJs9DWwC+roOmAy2ZQQXgvtanbrDxaxIXF+BlEbRrzccvKyzmhFigG X-Gm-Gg: ATEYQzwhlRdjaOhde5Sa14WBJEpiTMBHk8vrRED7p9Pi6pumkiv9yTggSLDXka8+KHZ /ok4ZuuJ98kZ0nXzLnS2fVqfRonMXLjomXDEXT65eu6BXmey86D6n//2auDq42VpiHvked/0vjE zkzm66cZpbT4ntN0PjHdMnBhIjJLhBlzDyJi1wgo1q1p/Tq84ovywBhdlpIHmDDJuS1NmNd41Ic VSy4VylNQCYKuWhJQyhZsDIO1QHcFMNUzs/SnbC/Yd4GsvbMZ8a6j5OW4p/4+1WHeFSBJJsHjN5 JK7LYXdGhz3oCVLFlNaFx0qKDmJ/xy1hSFcEPfxTMFACMZWr/e7ALhI/TzFqea8q0Zcq4TTuNL6 eXt9hap+EAC32oDIfudlGfoJopnG22/Nqag5qqM1qO//GMn1ZjU9Er91PI7e6X1fbwzijSY2YII 363q4/fJu3T7pBu/r9Qo6sfLfYCWfJk65F8aJ2 X-Received: by 2002:a17:907:6d05:b0:b97:b378:62ba with SMTP id a640c23a62f3a-b97b3786658mr484917966b.33.1773734862942; Tue, 17 Mar 2026 01:07:42 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cdb47fasm666212966b.43.2026.03.17.01.07.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 01:07:42 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 10:07:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/7] dt-bindings: iio: light: vcnl4000: add regulators To: Krzysztof Kozlowski Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> <20260316-vcnl4000-regulators-v4-1-854fc2eaf54b@gmail.com> <20260317-tricky-pony-of-assurance-7a8cac@quoll> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <20260317-tricky-pony-of-assurance-7a8cac@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/17/26 9:20 AM, Krzysztof Kozlowski wrote: > On Mon, Mar 16, 2026 at 07:19:45PM +0200, Erikas Bitovtas wrote: >> These sensors can accept 2 supplies - one for the sensor and one for IR >> LED [1]. Add supply properties for the sensor - 2 for the sensors and >> one external, for their I2C bus, to ensure the sensor is powered on >> before proceeding with setup. >> >> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf >> >> Reviewed-by: David Lechner >> Signed-off-by: Erikas Bitovtas >> --- >> Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> index 2ba4d5de4ec4..a1b4c02db246 100644 >> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> @@ -33,6 +33,10 @@ properties: >> interrupts: >> maxItems: 1 >> >> + vdd-supply: true >> + vddio-supply: true >> + vled-supply: true > > Same comments as before, I do not see improvements. > > Best regards, > Krzysztof > I explained why in v3. The message can be found here: https://lore.kernel.org/linux-iio/cb92bb47-9078-475d-b242-71e3f9181a72@baylibre.com/T/#m6da277894cf5c2b473fbeebd4b7bafc7519ebc26