public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-cachefs@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] netfs: Export netfs_put_subrequest()
Date: Thu, 19 May 2022 11:37:22 -0400	[thread overview]
Message-ID: <dabd25e5bc80be5cd2f7d04d6c119b644e706f47.camel@kernel.org> (raw)
In-Reply-To: <165296980976.3595490.4887936702439978407.stgit@warthog.procyon.org.uk>

On Thu, 2022-05-19 at 15:16 +0100, David Howells wrote:
> Export netfs_put_subrequest() and a couple of tracepoints.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Jeff Layton <jlayton@kernel.org>
> cc: linux-cachefs@redhat.com
> ---
> 
>  fs/netfs/main.c    |    3 +++
>  fs/netfs/objects.c |    1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/fs/netfs/main.c b/fs/netfs/main.c
> index 068568702957..3d0283f8d0b9 100644
> --- a/fs/netfs/main.c
> +++ b/fs/netfs/main.c
> @@ -15,6 +15,9 @@ MODULE_DESCRIPTION("Network fs support");
>  MODULE_AUTHOR("Red Hat, Inc.");
>  MODULE_LICENSE("GPL");
>  
> +EXPORT_TRACEPOINT_SYMBOL(netfs_rreq);
> +EXPORT_TRACEPOINT_SYMBOL(netfs_sreq);
> +
>  unsigned netfs_debug;
>  module_param_named(debug, netfs_debug, uint, S_IWUSR | S_IRUGO);
>  MODULE_PARM_DESC(netfs_debug, "Netfs support debugging mask");
> diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c
> index d6b8c0cbeb7c..cbc40d052b46 100644
> --- a/fs/netfs/objects.c
> +++ b/fs/netfs/objects.c
> @@ -160,3 +160,4 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, bool was_async,
>  	if (dead)
>  		netfs_free_subrequest(subreq, was_async);
>  }
> +EXPORT_SYMBOL(netfs_put_subrequest);
> 
> 

I don't see any callers of this outside of netfs. What's the rationale
for exporting it?
-- 
Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2022-05-19 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 14:16 [PATCH 1/2] netfs: ->cleanup() op is always given a rreq pointer now David Howells
2022-05-19 14:16 ` [PATCH 2/2] netfs: Export netfs_put_subrequest() David Howells
2022-05-19 15:37   ` Jeff Layton [this message]
2022-05-19 15:36 ` [PATCH 1/2] netfs: ->cleanup() op is always given a rreq pointer now Jeff Layton
2022-05-23  1:21   ` Xiubo Li
2022-05-23  6:08   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dabd25e5bc80be5cd2f7d04d6c119b644e706f47.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox