From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753702AbdKITrb (ORCPT ); Thu, 9 Nov 2017 14:47:31 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:44462 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbdKITra (ORCPT ); Thu, 9 Nov 2017 14:47:30 -0500 X-Google-Smtp-Source: AGs4zMZ4MF2xlOPudYyqwyzOMeWiuPB3ICg+gi2DFMkEEwdXhbxw/Kb9i8hy3YD8qx8BWxLIwuebtg== Subject: Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port" To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20171109143932.6923-1-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: Date: Thu, 9 Nov 2017 11:47:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171109143932.6923-1-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2017 06:39 AM, Vivien Didelot wrote: > We may have to pass a port's dedicated CPU port to port-wide functions > such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB. > > The DSA port-wide functions currently take a non-const struct dsa_port * > as first argument so we cannot make cpu_dp const yet, even though it'd > be more correct. Revert this patch and make cpu_dp non-const again. > > This reverts commit 24a9332a58b7f41a0d36c35a2c6897242bffdbc0. Missing signed-off-by, with that fixed: Reviewed-by: Florian Fainelli -- Florian