* [PATCH for-next 9/9] RDMA/rxe: get rid of create_user_ah
@ 2022-03-08 14:40 Yajun Deng
2022-03-09 13:43 ` Yanjun Zhu
0 siblings, 1 reply; 3+ messages in thread
From: Yajun Deng @ 2022-03-08 14:40 UTC (permalink / raw)
To: jgg, selvin.xavier, galpress, sleybo, liangwenpeng, liweihang,
mustafa.ismail, shiraz.saleem, leonro, dennis.dalessandro,
mike.marciniszyn, zyjzyj2000
Cc: linux-rdma, linux-kernel, Yajun Deng
There is no create_user_ah in ib_device_ops, remove it.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index 80df9a8f71a1..fa0cf2554425 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = {
.create_cq = rxe_create_cq,
.create_qp = rxe_create_qp,
.create_srq = rxe_create_srq,
- .create_user_ah = rxe_create_ah,
.dealloc_driver = rxe_dealloc,
.dealloc_mw = rxe_dealloc_mw,
.dealloc_pd = rxe_dealloc_pd,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-next 9/9] RDMA/rxe: get rid of create_user_ah
2022-03-08 14:40 [PATCH for-next 9/9] RDMA/rxe: get rid of create_user_ah Yajun Deng
@ 2022-03-09 13:43 ` Yanjun Zhu
2022-03-09 13:48 ` Yanjun Zhu
0 siblings, 1 reply; 3+ messages in thread
From: Yanjun Zhu @ 2022-03-09 13:43 UTC (permalink / raw)
To: Yajun Deng, jgg, selvin.xavier, galpress, sleybo, liangwenpeng,
liweihang, mustafa.ismail, shiraz.saleem, leonro,
dennis.dalessandro, mike.marciniszyn, zyjzyj2000
Cc: linux-rdma, linux-kernel
在 2022/3/8 22:40, Yajun Deng 写道:
> There is no create_user_ah in ib_device_ops, remove it.
In the file include/rdma/ib_verbs.h:
2305 struct ib_device_ops {
...
2431 int (*create_user_ah)(struct ib_ah *ah, struct
rdma_ah_init_attr *attr,
2432 struct ib_udata *udata);
...
create_user_ah exists.
Zhu Yanjun
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 80df9a8f71a1..fa0cf2554425 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = {
> .create_cq = rxe_create_cq,
> .create_qp = rxe_create_qp,
> .create_srq = rxe_create_srq,
> - .create_user_ah = rxe_create_ah,
> .dealloc_driver = rxe_dealloc,
> .dealloc_mw = rxe_dealloc_mw,
> .dealloc_pd = rxe_dealloc_pd,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-next 9/9] RDMA/rxe: get rid of create_user_ah
2022-03-09 13:43 ` Yanjun Zhu
@ 2022-03-09 13:48 ` Yanjun Zhu
0 siblings, 0 replies; 3+ messages in thread
From: Yanjun Zhu @ 2022-03-09 13:48 UTC (permalink / raw)
To: Yajun Deng, jgg, selvin.xavier, galpress, sleybo, liangwenpeng,
liweihang, mustafa.ismail, shiraz.saleem, leonro,
dennis.dalessandro, mike.marciniszyn, zyjzyj2000
Cc: linux-rdma, linux-kernel
在 2022/3/9 21:43, Yanjun Zhu 写道:
> 在 2022/3/8 22:40, Yajun Deng 写道:
>> There is no create_user_ah in ib_device_ops, remove it.
> In the file include/rdma/ib_verbs.h:
>
> 2305 struct ib_device_ops {
> ...
> 2431 int (*create_user_ah)(struct ib_ah *ah, struct
> rdma_ah_init_attr *attr,
> 2432 struct ib_udata *udata);
> ...
>
> create_user_ah exists.
I found your patch to remove create_user_ah.
IMO, you should merge the 2 patches as one.
Or after the patch to remove create_user_ah is merged in mainline,
then this patch can be sent out.
As such this will not misguide us.
Zhu Yanjun
>
> Zhu Yanjun
>>
>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>> ---
>> drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c
>> b/drivers/infiniband/sw/rxe/rxe_verbs.c
>> index 80df9a8f71a1..fa0cf2554425 100644
>> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
>> @@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = {
>> .create_cq = rxe_create_cq,
>> .create_qp = rxe_create_qp,
>> .create_srq = rxe_create_srq,
>> - .create_user_ah = rxe_create_ah,
>> .dealloc_driver = rxe_dealloc,
>> .dealloc_mw = rxe_dealloc_mw,
>> .dealloc_pd = rxe_dealloc_pd,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-09 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-08 14:40 [PATCH for-next 9/9] RDMA/rxe: get rid of create_user_ah Yajun Deng
2022-03-09 13:43 ` Yanjun Zhu
2022-03-09 13:48 ` Yanjun Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox