From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1DCC433FE for ; Wed, 9 Mar 2022 13:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232619AbiCINtV (ORCPT ); Wed, 9 Mar 2022 08:49:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbiCINtT (ORCPT ); Wed, 9 Mar 2022 08:49:19 -0500 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C672B149B91; Wed, 9 Mar 2022 05:48:19 -0800 (PST) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1646833696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qja1Ifb4XBFrqw5oPZs2VLQpDyt9RmXoFdLqOe6YM4c=; b=pIicI7HSATnbIQ2yU3vbIr6vepUDbWbbTKT/IZIrQjyCaHCDj5RAMwboQmhFlEYe+TpVa6 24MUjYN/pSpGz82CRg9Q+iGlPW48plXuMcY0Vjgza1cDKDVOna28kn3pJ/Qhh4FHQ/7kMr 4bweKYxPIemLV29IcuCt6ND3IUSSgc4= Date: Wed, 9 Mar 2022 21:48:05 +0800 MIME-Version: 1.0 Subject: Re: [PATCH for-next 9/9] RDMA/rxe: get rid of create_user_ah X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanjun Zhu To: Yajun Deng , jgg@nvidia.com, selvin.xavier@broadcom.com, galpress@amazon.com, sleybo@amazon.com, liangwenpeng@huawei.com, liweihang@huawei.com, mustafa.ismail@intel.com, shiraz.saleem@intel.com, leonro@nvidia.com, dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, zyjzyj2000@gmail.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220308144033.3406606-1-yajun.deng@linux.dev> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/3/9 21:43, Yanjun Zhu 写道: > 在 2022/3/8 22:40, Yajun Deng 写道: >> There is no create_user_ah in ib_device_ops, remove it. > In the file include/rdma/ib_verbs.h: > > 2305 struct ib_device_ops { > ... > 2431         int (*create_user_ah)(struct ib_ah *ah, struct > rdma_ah_init_attr *attr, > 2432                               struct ib_udata *udata); > ... > > create_user_ah exists. I found your patch to remove create_user_ah. IMO, you should merge the 2 patches as one. Or after the patch to remove create_user_ah is merged in mainline, then this patch can be sent out. As such this will not misguide us. Zhu Yanjun > > Zhu Yanjun >> >> Signed-off-by: Yajun Deng >> --- >>   drivers/infiniband/sw/rxe/rxe_verbs.c | 1 - >>   1 file changed, 1 deletion(-) >> >> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c >> b/drivers/infiniband/sw/rxe/rxe_verbs.c >> index 80df9a8f71a1..fa0cf2554425 100644 >> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c >> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c >> @@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = { >>       .create_cq = rxe_create_cq, >>       .create_qp = rxe_create_qp, >>       .create_srq = rxe_create_srq, >> -    .create_user_ah = rxe_create_ah, >>       .dealloc_driver = rxe_dealloc, >>       .dealloc_mw = rxe_dealloc_mw, >>       .dealloc_pd = rxe_dealloc_pd, >