From: "Pierre Asselin" <pa@panix.com>
To: "Javier Martinez Canillas" <javierm@redhat.com>
Cc: "Pierre Asselin" <pa@panix.com>,
dri-devel@lists.freedesktop.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] firmware/sysfb: Fix VESA format selection
Date: Wed, 19 Apr 2023 15:56:29 -0400 [thread overview]
Message-ID: <daef19bc1a59c0bb19fc78b2cdedf07d.squirrel@mail.panix.com> (raw)
In-Reply-To: <87bkjki8p8.fsf@minerva.mail-host-address-is-not-set>
Javier Martinez Canillas <javierm@redhat.com> writes:
> Pierre Asselin <pa@panix.com> writes:
>> Fixes: f35cd3fa7729 [firmware/sysfb: Fix EFI/VESA format selection]
>
> The convention is f35cd3fa7729 ("firmware/sysfb: Fix EFI/VESA format
> selection")
>> + bits_per_pixel= max(bits_per_pixel, (u32)si->lfb_depth);
>
> You are missing a space here.
OK. I'll fix that. Thanks.
--PA
prev parent reply other threads:[~2023-04-19 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 4:48 [PATCH v2] firmware/sysfb: Fix VESA format selection Pierre Asselin
2023-04-19 7:14 ` Thomas Zimmermann
2023-04-19 20:27 ` Pierre Asselin
2023-04-20 8:22 ` Thomas Zimmermann
2023-04-19 8:21 ` Javier Martinez Canillas
2023-04-19 19:56 ` Pierre Asselin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef19bc1a59c0bb19fc78b2cdedf07d.squirrel@mail.panix.com \
--to=pa@panix.com \
--cc=ardb@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox