From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: uttkarsh.aggarwal@oss.qualcomm.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, mathias.nyman@intel.com,
wesley.cheng@oss.qualcomm.com
Subject: Re: [RFT PATCH] xhci: sideband: Fix race condition in sideband unregister
Date: Tue, 28 Oct 2025 16:59:18 +0200 [thread overview]
Message-ID: <db07f48d-27cf-4681-b10e-38d252e24512@linux.intel.com> (raw)
In-Reply-To: <2025102808-sublime-substance-74bb@gregkh>
On 10/28/25 15:56, Greg KH wrote:
>> @@ -474,16 +494,23 @@ xhci_sideband_unregister(struct xhci_sideband *sb)
>> xhci = sb->xhci;
>>
>> mutex_lock(&sb->mutex);
>> +
>> + vdev = sb->vdev;
>> + if (!vdev)
>> + return;
>
> Lock is still held :(
>
Oops, missed one
> I think you need to use guard() to make this more sane.
Clearly yes, I'll send a v2
>
> thanks,
>
> greg k-h
>
Thanks
Mathias
next prev parent reply other threads:[~2025-10-28 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 8:00 [PATCH] xhci: sideband: Fix race condition in sideband unregister Uttkarsh Aggarwal
2025-10-28 8:45 ` Greg Kroah-Hartman
2025-10-28 12:15 ` Mathias Nyman
2025-10-28 13:44 ` [RFT PATCH] " Mathias Nyman
2025-10-28 13:56 ` Greg KH
2025-10-28 14:59 ` Mathias Nyman [this message]
2025-10-28 16:51 ` [RFT PATCH v2] " Mathias Nyman
2025-10-29 10:14 ` Greg KH
2025-10-29 12:24 ` [RFT PATCH v3] " Mathias Nyman
2025-10-29 12:51 ` Greg KH
2025-10-29 13:52 ` Mathias Nyman
2025-11-07 6:16 ` Uttkarsh Aggarwal
2025-11-07 16:05 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db07f48d-27cf-4681-b10e-38d252e24512@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=uttkarsh.aggarwal@oss.qualcomm.com \
--cc=wesley.cheng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox